-
Notifications
You must be signed in to change notification settings - Fork 14.4k
[GlobalISel] Remove dead code. (NFC) #145811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LegalizerHelper::lowerMemCpyFamily only execpts G_MEMCPY, G_MEMMOVE, and G_MMSET.
@llvm/pr-subscribers-llvm-globalisel Author: Pete Chou (petechou) ChangesLegalizerHelper::lowerMemCpyFamily only execpts G_MEMCPY, G_MEMMOVE, and Full diff: https://github.com/llvm/llvm-project/pull/145811.diff 1 Files Affected:
diff --git a/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp b/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
index 461fc35337eac..b87b029d01632 100644
--- a/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
+++ b/llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
@@ -10099,10 +10099,6 @@ LegalizerHelper::lowerMemCpyFamily(MachineInstr &MI, unsigned MaxLen) {
}
bool IsVolatile = MemOp->isVolatile();
- if (Opc == TargetOpcode::G_MEMCPY_INLINE)
- return lowerMemcpyInline(MI, Dst, Src, KnownLen, DstAlign, SrcAlign,
- IsVolatile);
-
// Don't try to optimize volatile.
if (IsVolatile)
return UnableToLegalize;
|
if (Opc == TargetOpcode::G_MEMCPY_INLINE) | ||
return lowerMemcpyInline(MI, Dst, Src, KnownLen, DstAlign, SrcAlign, | ||
IsVolatile); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This lowerMemcpyInline overload is also probably dead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I guess it's not. It's used in LegalizerHelper::lowerMemcpyInline(MachineInstr &MI)
which is called by CombinerHelper::tryEmitMemcpyInline(MachineInstr &MI)
from target pre-legalizer combiner.
LegalizerHelper::lowerMemCpyFamily only execpts G_MEMCPY, G_MEMMOVE, and G_MMSET.
LegalizerHelper::lowerMemCpyFamily only execpts G_MEMCPY, G_MEMMOVE, and G_MMSET.
LegalizerHelper::lowerMemCpyFamily only execpts G_MEMCPY, G_MEMMOVE, and
G_MMSET.