Skip to content

[mlir][affine] NFC Rename SimplifyAffineMinMax -> SimplifyAffineMinMa… #145905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2025

Conversation

nicolasvasilache
Copy link
Contributor

…xPass

This is more consistent re. auto-generated names like createSimplifyAffineMinMaxPass.

…xPass

This is more consistent re. auto-generated names like `createSimplifyAffineMinMaxPass`.
@nicolasvasilache nicolasvasilache merged commit 5bf4363 into main Jun 26, 2025
8 of 10 checks passed
@nicolasvasilache nicolasvasilache deleted the users/nico/rename branch June 26, 2025 14:34
@llvmbot
Copy link
Member

llvmbot commented Jun 26, 2025

@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-affine

Author: Nicolas Vasilache (nicolasvasilache)

Changes

…xPass

This is more consistent re. auto-generated names like createSimplifyAffineMinMaxPass.


Full diff: https://github.com/llvm/llvm-project/pull/145905.diff

2 Files Affected:

  • (modified) mlir/include/mlir/Dialect/Affine/Passes.td (+1-1)
  • (modified) mlir/lib/Dialect/Affine/Transforms/SimplifyAffineMinMax.cpp (+3-2)
diff --git a/mlir/include/mlir/Dialect/Affine/Passes.td b/mlir/include/mlir/Dialect/Affine/Passes.td
index bc7ffe23e7f52..6ad45b828f657 100644
--- a/mlir/include/mlir/Dialect/Affine/Passes.td
+++ b/mlir/include/mlir/Dialect/Affine/Passes.td
@@ -414,7 +414,7 @@ def SimplifyAffineStructures : Pass<"affine-simplify-structures", "func::FuncOp"
   let constructor = "mlir::affine::createSimplifyAffineStructuresPass()";
 }
 
-def SimplifyAffineMinMax : InterfacePass<"affine-simplify-min-max", "FunctionOpInterface"> {
+def SimplifyAffineMinMaxPass : InterfacePass<"affine-simplify-min-max", "FunctionOpInterface"> {
   let summary = "Simplify affine min/max/apply";
   let description = [{
     Apply the SimplifyAffineMaxOp, SimplifyAffineMinOp and SimplifyAffineApplyOp
diff --git a/mlir/lib/Dialect/Affine/Transforms/SimplifyAffineMinMax.cpp b/mlir/lib/Dialect/Affine/Transforms/SimplifyAffineMinMax.cpp
index 21443a55a35ad..2cb78d2b94c63 100644
--- a/mlir/lib/Dialect/Affine/Transforms/SimplifyAffineMinMax.cpp
+++ b/mlir/lib/Dialect/Affine/Transforms/SimplifyAffineMinMax.cpp
@@ -240,14 +240,15 @@ struct SimplifyAffineApplyOp : public OpRewritePattern<AffineApplyOp> {
 
 namespace mlir {
 namespace affine {
-#define GEN_PASS_DEF_SIMPLIFYAFFINEMINMAX
+#define GEN_PASS_DEF_SIMPLIFYAFFINEMINMAXPASS
 #include "mlir/Dialect/Affine/Passes.h.inc"
 } // namespace affine
 } // namespace mlir
 
 /// Creates a simplification pass for affine min/max/apply.
 struct SimplifyAffineMinMaxPass
-    : public affine::impl::SimplifyAffineMinMaxBase<SimplifyAffineMinMaxPass> {
+    : public affine::impl::SimplifyAffineMinMaxPassBase<
+          SimplifyAffineMinMaxPass> {
   void runOnOperation() override;
 };
 

nicolasvasilache added a commit to iree-org/llvm-project that referenced this pull request Jun 26, 2025
llvm#145905)

…xPass

This is more consistent re. auto-generated names like `createSimplifyAffineMinMaxPass`.
anthonyhatran pushed a commit to anthonyhatran/llvm-project that referenced this pull request Jun 26, 2025
llvm#145905)

…xPass

This is more consistent re. auto-generated names like `createSimplifyAffineMinMaxPass`.
rlavaee pushed a commit to rlavaee/llvm-project that referenced this pull request Jul 1, 2025
llvm#145905)

…xPass

This is more consistent re. auto-generated names like `createSimplifyAffineMinMaxPass`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants