[NFC][HLSL][DirectX] Let HLSLRootSignature reuse the dxbc defined enums
#145986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inbelic
changed the title
HLSLRootSignature reuse the dxbc defined enumsHLSLRootSignature reuse the dxbc defined enums
spall
reviewed
Jun 27, 2025
| ComparisonFunc CompFunc = ComparisonFunc::LessEqual; | ||
| StaticBorderColor BorderColor = StaticBorderColor::OpaqueWhite; | ||
| llvm::dxbc::ComparisonFunc CompFunc = llvm::dxbc::ComparisonFunc::LessEqual; | ||
| dxbc::StaticBorderColor BorderColor = dxbc::StaticBorderColor::OpaqueWhite; |
There was a problem hiding this comment.
is there a distinction between llvm::dxcbc and dxbc? I noticed a few other places where you used both right by eachother.
There was a problem hiding this comment.
Nope, they should be consistent across each file, thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr removes the redundancy of having the same enums defined in both the front-end and back-end of handling root signatures. Since there are many more uses of the enum in the front-end of the code, we will adhere to the naming conventions used in the front-end, to minimize the diff.
The macros in
DXContainerConstants.defare also touched-up to be consistent and to have each macro name follow its respective definition in d3d12.h and searchable by name here.Additionally, the many
getEnumNamesare moved toDXContainerfromHLSLRootSignatureUtilsas they we will want them to be exposed publicly anyways.Changes for each enum follow the pattern of a commit that will make the enum definition in
DXContaineradhere to above listed naming conventions, followed by a commit to actually use that enum in the front-end.Resolves #145815