Skip to content

[Clang][NFC] - Move attr-cpuspecific-cpus test over to Sema #146065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2025

Conversation

pawan-nirpal-031
Copy link
Contributor

The attr-cpuspecific-cpus test does not have any LLVM IR checks relevant to Codegen, Moving the test over to clang/test/Sema.

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Jun 27, 2025
@llvmbot
Copy link
Member

llvmbot commented Jun 27, 2025

@llvm/pr-subscribers-clang

Author: Pawan Nirpal (pawan-nirpal-031)

Changes

The attr-cpuspecific-cpus test does not have any LLVM IR checks relevant to Codegen, Moving the test over to clang/test/Sema.


Full diff: https://github.com/llvm/llvm-project/pull/146065.diff

1 Files Affected:

  • (renamed) clang/test/Sema/attr-cpuspecific-cpus.c (+2-2)
diff --git a/clang/test/CodeGen/attr-cpuspecific-cpus.c b/clang/test/Sema/attr-cpuspecific-cpus.c
similarity index 97%
rename from clang/test/CodeGen/attr-cpuspecific-cpus.c
rename to clang/test/Sema/attr-cpuspecific-cpus.c
index 1dd095ec9e191..6f26b2012c4f4 100644
--- a/clang/test/CodeGen/attr-cpuspecific-cpus.c
+++ b/clang/test/Sema/attr-cpuspecific-cpus.c
@@ -1,5 +1,5 @@
-// RUN: %clang_cc1 -verify -triple x86_64-linux-gnu -emit-llvm -o - %s
-// RUN: %clang_cc1 -verify -triple x86_64-windows-pc -fms-compatibility -emit-llvm -o - %s
+// RUN: %clang_cc1 -verify -triple x86_64-linux-gnu -o - %s
+// RUN: %clang_cc1 -verify -triple x86_64-windows-pc -fms-compatibility -o - %s
 
 // expected-no-diagnostics
 

@pawan-nirpal-031
Copy link
Contributor Author

@AaronBallman can you please review.

Co-authored-by: Aaron Ballman <aaron@aaronballman.com>
Copy link
Collaborator

@AaronBallman AaronBallman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming precommit CI comes back green, thanks!

@AaronBallman AaronBallman merged commit 2cbcec4 into llvm:main Jun 27, 2025
7 checks passed
@pawan-nirpal-031 pawan-nirpal-031 deleted the move-cpuspecific-attrstosema branch June 27, 2025 15:20
rlavaee pushed a commit to rlavaee/llvm-project that referenced this pull request Jul 1, 2025
)

The attr-cpuspecific-cpus test does not have any LLVM IR checks relevant
to Codegen, Moving the test over to clang/test/Sema.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants