fix `Intl.Segments#containing` return value type #61236

petamoriken · 2025-02-20T15:53:02Z

jakebailey · 2025-02-22T00:23:59Z

typescript-bot · 2025-02-22T00:24:03Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-02-22T00:45:59Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/61236/merge:

Everything looks good!

typescript-bot · 2025-02-22T00:46:27Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-02-22T01:08:58Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,390	_62,390	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,160k (± 0.98%)}	_{193,500k (± 0.75%)}	_~	_192,881k	_196,476k	_{p=0.128 n=6}
_{Parse Time}	_{1.31s (± 0.48%)}	_{1.31s (± 0.31%)}	_~	_1.31s	_1.32s	_{p=0.673 n=6}
_{Bind Time}	_0.73s	_0.73s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.72s (± 0.50%)}	_{9.73s (± 0.28%)}	_~	_9.69s	_9.76s	_{p=0.936 n=6}
_{Emit Time}	_{2.73s (± 0.36%)}	_{2.73s (± 0.79%)}	_~	_2.70s	_2.76s	_{p=0.803 n=6}
_{Total Time}	_{14.49s (± 0.33%)}	_{14.50s (± 0.18%)}	_~	_14.47s	_14.53s	_{p=0.871 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,488	_948,488	_~	_~	_~	_{p=1.000 n=6}
_Types	_411,006	_411,006	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,182k (± 0.00%)}	_{1,224,200k (± 0.01%)}	_~	_1,224,127k	_1,224,309k	_{p=0.810 n=6}
_{Parse Time}	_{6.67s (± 0.76%)}	_{6.64s (± 0.69%)}	_~	_6.55s	_6.68s	_{p=0.332 n=6}
_{Bind Time}	_{1.88s (± 0.64%)}	_{1.90s (± 0.73%)}	_~	_1.88s	_1.91s	_{p=0.191 n=6}
_{Check Time}	_{31.78s (± 0.28%)}	_{31.78s (± 0.29%)}	_~	_31.66s	_31.93s	_{p=0.809 n=6}
_{Emit Time}	_{15.26s (± 0.63%)}	_{15.25s (± 0.61%)}	_~	_15.12s	_15.41s	_{p=1.000 n=6}
_{Total Time}	_{55.58s (± 0.26%)}	_{55.56s (± 0.26%)}	_~	_55.38s	_55.76s	_{p=1.000 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,347,440	_2,347,440	_~	_~	_~	_{p=1.000 n=6}
_Types	_845,526	_845,526	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,120,374k (± 0.00%)}	_{2,120,392k (± 0.00%)}	_~	_2,120,351k	_2,120,452k	_{p=0.298 n=6}
_{Parse Time}	_{7.27s (± 0.22%)}	_{7.25s (± 0.12%)}	_~	_7.24s	_7.26s	_{p=0.070 n=6}
_{Bind Time}	_{2.45s (± 0.84%)}	_{2.44s (± 0.67%)}	_~	_2.42s	_2.46s	_{p=0.808 n=6}
_{Check Time}	_{72.70s (± 0.26%)}	_{72.62s (± 0.37%)}	_~	_72.25s	_73.00s	_{p=0.521 n=6}
_{Emit Time}	_{0.15s (± 3.52%)}	_{0.15s (± 3.52%)}	_~	_0.14s	_0.15s	_{p=1.000 n=6}
_{Total Time}	_{82.55s (± 0.23%)}	_{82.46s (± 0.32%)}	_~	_82.12s	_82.85s	_{p=0.575 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,588	_1,226,588	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,986	_266,986	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,602,406k (±14.48%)}	_{2,846,378k (±13.17%)}	_~	_2,359,521k	_3,090,072k	_{p=0.298 n=6}
_{Parse Time}	_{6.64s (± 1.80%)}	_{6.70s (± 1.51%)}	_~	_6.55s	_6.78s	_{p=0.521 n=6}
_{Bind Time}	_{2.14s (± 1.74%)}	_{2.18s (± 1.46%)}	_~	_2.14s	_2.21s	_{p=0.294 n=6}
_{Check Time}	_{42.72s (± 0.60%)}	_{42.98s (± 0.55%)}	_~	_42.73s	_43.41s	_{p=0.298 n=6}
_{Emit Time}	_{3.54s (± 4.63%)}	_{3.50s (± 3.21%)}	_~	_3.41s	_3.71s	_{p=0.689 n=6}
_{Total Time}	_{55.05s (± 0.53%)}	_{55.36s (± 0.60%)}	_~	_54.91s	_55.91s	_{p=0.128 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,588	_1,226,588	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,986	_266,986	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,424,434k (± 0.01%)}	_{2,424,646k (± 0.04%)}	_~	_2,424,001k	_2,426,424k	_{p=0.936 n=6}
_{Parse Time}	_{5.44s (± 0.76%)}	_{5.47s (± 0.99%)}	_~	_5.40s	_5.53s	_{p=0.520 n=6}
_{Bind Time}	_{1.78s (± 1.39%)}	_{1.78s (± 1.11%)}	_~	_1.76s	_1.81s	_{p=1.000 n=6}
_{Check Time}	_{35.37s (± 0.19%)}	_{35.35s (± 0.36%)}	_~	_35.22s	_35.50s	_{p=0.936 n=6}
_{Emit Time}	_{3.07s (± 0.78%)}	_{3.08s (± 4.67%)}	_~	_2.96s	_3.36s	_{p=0.336 n=6}
_{Total Time}	_{45.67s (± 0.18%)}	_{45.67s (± 0.50%)}	_~	_45.42s	_46.06s	_{p=0.810 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,667	_262,667	_~	_~	_~	_{p=1.000 n=6}
_Types	_106,849	_106,849	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{440,478k (± 0.01%)}	_{440,477k (± 0.01%)}	_~	_440,389k	_440,517k	_{p=0.936 n=6}
_{Parse Time}	_{3.52s (± 0.90%)}	_{3.53s (± 0.75%)}	_~	_3.49s	_3.57s	_{p=0.413 n=6}
_{Bind Time}	_{1.32s (± 1.05%)}	_{1.31s (± 0.89%)}	_~	_1.30s	_1.33s	_{p=0.737 n=6}
_{Check Time}	_{18.91s (± 0.28%)}	_{18.90s (± 0.38%)}	_~	_18.79s	_18.97s	_{p=1.000 n=6}
_{Emit Time}	_{1.52s (± 0.83%)}	_{1.52s (± 1.18%)}	_~	_1.49s	_1.54s	_{p=0.934 n=6}
_{Total Time}	_{25.27s (± 0.20%)}	_{25.27s (± 0.30%)}	_~	_25.15s	_25.34s	_{p=0.748 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,113	_226,113	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,427k (± 0.05%)}	_{371,450k (± 0.06%)}	_~	_371,308k	_371,856k	_{p=0.689 n=6}
_{Parse Time}	_{2.88s (± 0.72%)}	_{2.90s (± 1.22%)}	_~	_2.85s	_2.95s	_{p=0.376 n=6}
_{Bind Time}	_{1.59s (± 1.67%)}	_{1.61s (± 0.83%)}	_~	_1.60s	_1.63s	_{p=0.199 n=6}
_{Check Time}	_{16.45s (± 0.27%)}	_{16.45s (± 0.31%)}	_~	_16.39s	_16.52s	_{p=0.872 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.92s (± 0.24%)}	_{20.96s (± 0.20%)}	_~	_20.91s	_21.03s	_{p=0.468 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,230,017	_3,230,017	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,095,648	_1,095,648	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,306,674k (± 0.01%)}	_{3,306,605k (± 0.01%)}	_~	_3,305,824k	_3,306,959k	_{p=1.000 n=6}
_{Parse Time}	_{14.38s (± 0.55%)}	_{14.38s (± 0.45%)}	_~	_14.31s	_14.46s	_{p=0.872 n=6}
_{Bind Time}	_{4.60s (± 0.43%)}	_{4.62s (± 0.92%)}	_~	_4.57s	_4.67s	_{p=0.809 n=6}
_{Check Time}	_{89.77s (± 1.85%)}	_{89.46s (± 2.88%)}	_~	_87.32s	_94.29s	_{p=0.575 n=6}
_{Emit Time}	_{27.63s (± 0.75%)}	_{27.75s (± 1.76%)}	_~	_27.47s	_28.74s	_{p=0.873 n=6}
_{Total Time}	_{136.38s (± 1.21%)}	_{136.21s (± 1.88%)}	_~	_133.81s	_140.88s	_{p=0.630 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₂	₂	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_293,866	_293,866	_~	_~	_~	_{p=1.000 n=6}
_Types	_119,628	_119,628	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{447,068k (± 0.02%)}	_{447,182k (± 0.01%)}	_~	_447,103k	_447,245k	_{p=0.054 n=6}
_{Parse Time}	_{4.07s (± 1.19%)}	_{4.08s (± 1.19%)}	_~	_4.01s	_4.15s	_{p=1.000 n=6}
_{Bind Time}	_{1.76s (± 1.52%)}	_{1.75s (± 1.43%)}	_~	_1.72s	_1.79s	_{p=0.934 n=6}
_{Check Time}	_{18.77s (± 0.37%)}	_{18.84s (± 0.22%)}	_~	_18.78s	_18.89s	_{p=0.078 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.61s (± 0.13%)}	_{24.67s (± 0.30%)}	_{+0.06s (+ 0.26%)}	_24.58s	_24.80s	_{p=0.043 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_559,094	_559,094	_~	_~	_~	_{p=1.000 n=6}
_Types	_187,011	_187,011	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{496,237k (± 0.01%)}	_{496,240k (± 0.02%)}	_~	_496,177k	_496,385k	_{p=0.575 n=6}
_{Parse Time}	_{3.42s (± 0.68%)}	_{3.42s (± 0.69%)}	_~	_3.39s	_3.46s	_{p=1.000 n=6}
_{Bind Time}	_{1.20s (± 0.53%)}	_{1.19s (± 1.14%)}	_~	_1.18s	_1.21s	_{p=0.362 n=6}
_{Check Time}	_{19.57s (± 0.26%)}	_{19.64s (± 0.45%)}	_~	_19.55s	_19.76s	_{p=0.253 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.19s (± 0.19%)}	_{24.25s (± 0.31%)}	_~	_24.16s	_24.35s	_{p=0.149 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-02-22T01:58:26Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61236/merge:

Everything looks good!

petamoriken · 2025-04-28T06:32:16Z

@jakebailey Hi. I think this PR can be merged, how about it?

DanielRosenwasser · 2025-05-15T16:03:18Z

src/lib/es2022.intl.d.ts

         * @param codeUnitIndex - A number specifying the index of the code unit in the original input string. If the value is omitted, it defaults to `0`.
         */
-        containing(codeUnitIndex?: number): SegmentData;
+        containing(codeUnitIndex?: number): SegmentData | undefined;


It's unfortunate because this would ideally be tied to noUncheckedIndexedAccess or something.

DanielRosenwasser · 2025-07-02T00:10:54Z

Thank you!

petamoriken added 2 commits February 21, 2025 00:51

fix Intl.Segments#containing return value type

3a1e241

format

3e59841

petamoriken mentioned this pull request May 15, 2025

TypeScript 5.9 Iteration Plan #61648

Open

DanielRosenwasser reviewed May 15, 2025

View reviewed changes

DanielRosenwasser approved these changes Jul 2, 2025

View reviewed changes

github-project-automation bot moved this from Not started to Needs merge in PR Backlog Jul 2, 2025

DanielRosenwasser merged commit 8518a87 into microsoft:main Jul 2, 2025
32 checks passed

github-project-automation bot moved this to Done in lavitaconnect@MOSTAFAAMMER Jul 2, 2025

github-project-automation bot moved this from Needs merge to Done in PR Backlog Jul 2, 2025

petamoriken deleted the fix/intl-segmenter branch July 3, 2025 14:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix `Intl.Segments#containing` return value type #61236

fix `Intl.Segments#containing` return value type #61236

Uh oh!

petamoriken commented Feb 20, 2025

Uh oh!

jakebailey commented Feb 22, 2025

Uh oh!

typescript-bot commented Feb 22, 2025 •

edited

Loading

Uh oh!

typescript-bot commented Feb 22, 2025

Uh oh!

typescript-bot commented Feb 22, 2025

Uh oh!

typescript-bot commented Feb 22, 2025

tsc

Uh oh!

typescript-bot commented Feb 22, 2025

Uh oh!

petamoriken commented Apr 28, 2025

Uh oh!

DanielRosenwasser May 15, 2025 •

edited

Loading

Uh oh!

Uh oh!

DanielRosenwasser commented Jul 2, 2025

Uh oh!

Uh oh!

fix Intl.Segments#containing return value type #61236

fix Intl.Segments#containing return value type #61236

Uh oh!

Conversation

petamoriken commented Feb 20, 2025

Uh oh!

jakebailey commented Feb 22, 2025

Uh oh!

typescript-bot commented Feb 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 22, 2025

Uh oh!

typescript-bot commented Feb 22, 2025

Uh oh!

typescript-bot commented Feb 22, 2025

tsc

Uh oh!

typescript-bot commented Feb 22, 2025

Uh oh!

petamoriken commented Apr 28, 2025

Uh oh!

DanielRosenwasser May 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DanielRosenwasser commented Jul 2, 2025

Uh oh!

Uh oh!

fix `Intl.Segments#containing` return value type #61236

fix `Intl.Segments#containing` return value type #61236

typescript-bot commented Feb 22, 2025 •

edited

Loading

DanielRosenwasser May 15, 2025 •

edited

Loading