Skip to content

Commit a783d8a

Browse files
authored
Node: Check debug mode for debug logs (#1046)
* check debug mode for debug logs * Bump package version * Update changelog * re-bump version * Use dynamic feature flag variable * Fix condition
1 parent 51ae910 commit a783d8a

File tree

4 files changed

+18
-6
lines changed

4 files changed

+18
-6
lines changed

node/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
## 4.x
44

5+
## 4.15.0
6+
7+
- Disabled debug logs when debug mode is not enabled - [#1046](https://github.com/microsoft/azure-pipelines-task-lib/pull/1046)
8+
59
## 4.12.1
610

711
- Remove deasync from task-lib - [#1038](https://github.com/microsoft/azure-pipelines-task-lib/pull/1038)

node/internal.ts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -344,8 +344,16 @@ export function _error(
344344
);
345345
}
346346

347+
const debugMode = _getVariable('system.debug')?.toLowerCase() === 'true';
348+
const shouldCheckDebugMode = _getVariable('DistributedTask.Tasks.Node.SkipDebugLogsWhenDebugModeOff')?.toLowerCase() === 'true';
349+
347350
export function _debug(message: string): void {
348-
_command('task.debug', null, message);
351+
if (
352+
!shouldCheckDebugMode
353+
|| (shouldCheckDebugMode && debugMode)
354+
) {
355+
_command('task.debug', null, message);
356+
}
349357
}
350358

351359
// //-----------------------------------------------------

node/package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

node/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "azure-pipelines-task-lib",
3-
"version": "4.14.0",
3+
"version": "4.15.0",
44
"description": "Azure Pipelines Task SDK",
55
"main": "./task.js",
66
"typings": "./task.d.ts",

0 commit comments

Comments
 (0)