Replace Array.flat() with custom flattenArray() function for Node.js compatibility #1105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rishabhmalikMS
changed the title
|
changes looks good, can we please update canary test pipeline to have this test case |
sanjuyadav24
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current code uses Array.flat() which is only available in Node.js versions >= 12. This causes compatibility issues when running on older Node.js versions that are still supported by Azure Pipelines agents.
Changes
Github Issue Link: microsoft/azure-pipelines-tasks#21048
Testing
Tested with already existing unit tests having multiple paths as input to LS function in an array.