-
Notifications
You must be signed in to change notification settings - Fork 72
[optimizer] Replace value.nbytes with value.size #2399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[optimizer] Replace value.nbytes with value.size #2399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2399 +/- ##
=======================================
Coverage 70.38% 70.38%
=======================================
Files 199 199
Lines 25223 25223
Branches 2686 2686
=======================================
Hits 17754 17754
Misses 6540 6540
Partials 929 929 ☔ View full report in Codecov by Sentry. |
I should probably set a compatible default as the previous one (now in different scale...) |
@copilot can you help update the documentation? (ok maybe not) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is a merge conflict
To unify the size limitation in terms of the scale.
Passes use tensor size:
https://github.com/onnx/ir-py/blob/a833ab1e178c70046a414b96c1aafbf78a9b4e17/src/onnx_ir/passes/common/constant_manipulation.py#L124
while optimizer uses nbytes, which could potentially confuse users.