-
Notifications
You must be signed in to change notification settings - Fork 66
Move _c_api_utils.py to version_converter package #2401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
4
commits into
main
Choose a base branch
from
copilot/fix-2400
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: justinchuby <11205048+justinchuby@users.noreply.github.com>
Copilot finished work on behalf of
justinchuby
June 18, 2025 20:24
justinchuby
approved these changes
Jun 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Be sure to run
pip install lintrunner lintrunner-adapters
lintrunner init
lintrunner f --all-files
to format the code
❌ 14 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Co-authored-by: justinchuby <11205048+justinchuby@users.noreply.github.com>
... Ran lintrunner as requested to format the code. Changes committed in 79a31c5. |
justinchuby
approved these changes
Jun 18, 2025
titaiwangms
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves
_c_api_utils.py
fromonnxscript/ir/passes/common/
toonnxscript/version_converter/
since it's only used by the version converter module.Changes
onnxscript/ir/passes/common/_c_api_utils.py
toonnxscript/version_converter/_c_api_utils.py
onnxscript/version_converter/__init__.py
fromfrom onnxscript.ir.passes.common import _c_api_utils
tofrom . import _c_api_utils
Analysis
A codebase analysis confirmed that
_c_api_utils.py
is only imported and used by the version converter:call_onnx_api
functiononnxscript/version_converter/__init__.py
__all__
listsMoving the file to the version converter package improves code organization by colocating the utility with its sole consumer.
Fixes #2400.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.