Add edit functionality to fourslash
#1310
Open
+2,423
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The git diff is showing stuff I think has already been merged in main; bad merge maybe? |
No, I'm just rebasing and re-generating stuff right now, you just looked before I'm done with it 😅 |
gabritto
commented
Jun 27, 2025
|
|
||
| testData *TestData | ||
| testData *TestData // !!! consolidate test files from test data and script info |
There was a problem hiding this comment.
Weirdly some requests in Strada's fourslash use the original files instead of the fourslash object's script info with the updated content, so I'm not sure how things are gonna go and have kept the whole test data here for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functions like
edit.insert(...)to fourslash, and enables the test conversion script to convert Strada tests that use those functions.Note that the fourslash test object now has to keep track of file changes, so it has a map of
scriptInfos. It also has to convert between absolute positions and LSP positions.This PR adds 41 new converted tests, 24 of which are skipped due to failing.