Build Error on riscv64

[alitariq4589]

Version

trunk of repo

Platform

Linux pioneer-128G-1 6.6.66-pioneer #2024.12.27.05.50+c30fe9b9c SMP Fri Dec 27 06:19:30 UTC 2024 riscv64 GNU/Linux

Subsystem

No response

What steps will reproduce the bug?

cd node
./configure --prefix=$(readlink -f ../installed_binaries) --openssl-no-asm --dest-cpu=riscv64
make -j32

Complete CI file can be found here: https://github.com/alitariq4589/cloud-v-builds/blob/main/nodejs

How often does it reproduce? Is there a required condition?

Every time I build the master branch now, this issue appears in riscv64 on debian trixie

What is the expected behavior? Why is that the expected behavior?

To build properly from source

What do you see instead?

Complete log of the build can be found here: https://dash.cloud-v.co/view/Cloud-V%20Builds/job/cloud-v-builds-folder/job/node-riscv-build/18/consoleFull

make[1]: *** [tools/v8_gypfiles/v8_compiler.target.mk:379: /home/riscv-builds/runner_dir/workspace/cloud-v-builds-folder/node-riscv-build/node/out/Release/obj.target/v8_compiler/deps/v8/src/compiler/backend/jump-threading.o] Error 1
make[1]: *** Waiting for unfinished jobs....
In file included from ../deps/v8/src/codegen/macro-assembler.h:82,
                 from ../deps/v8/src/maglev/maglev-ir.cc:18:
../deps/v8/src/codegen/riscv/macro-assembler-riscv.h:409:13: error: explicit specialization in non-namespace scope ‘class v8::internal::MacroAssembler’
  409 |   template <>
      |             ^
../deps/v8/src/codegen/riscv/macro-assembler-riscv.h:557:13: error: explicit specialization in non-namespace scope ‘class v8::internal::MacroAssembler’
  557 |   template <>
      |             ^
In file included from ../deps/v8/src/codegen/macro-assembler.h:82,
                 from ../deps/v8/src/compiler/backend/instruction-selector-impl.h:8,
                 from ../deps/v8/src/compiler/backend/instruction-selector.cc:16:
../deps/v8/src/codegen/riscv/macro-assembler-riscv.h:409:13: error: explicit specialization in non-namespace scope ‘class v8::internal::MacroAssembler’
  409 |   template <>
      |             ^
../deps/v8/src/codegen/riscv/macro-assembler-riscv.h:557:13: error: explicit specialization in non-namespace scope ‘class v8::internal::MacroAssembler’
  557 |   template <>
      |             ^
In file included from ../deps/v8/src/codegen/macro-assembler.h:82,
                 from ../deps/v8/src/compiler/c-linkage.cc:6:
../deps/v8/src/codegen/riscv/macro-assembler-riscv.h:409:13: error: explicit specialization in non-namespace scope ‘class v8::internal::MacroAssembler’
  409 |   template <>
      |             ^
../deps/v8/src/codegen/riscv/macro-assembler-riscv.h:557:13: error: explicit specialization in non-namespace scope ‘class v8::internal::MacroAssembler’
  557 |   template <>
      |             ^
make[1]: *** [tools/v8_gypfiles/v8_compiler.target.mk:379: /home/riscv-builds/runner_dir/workspace/cloud-v-builds-folder/node-riscv-build/node/out/Release/obj.target/v8_compiler/deps/v8/src/compiler/c-linkage.o] Error 1
make[1]: *** [tools/v8_gypfiles/v8_compiler.target.mk:379: /home/riscv-builds/runner_dir/workspace/cloud-v-builds-folder/node-riscv-build/node/out/Release/obj.target/v8_compiler/deps/v8/src/compiler/backend/code-generator.o] Error 1
make[1]: *** [tools/v8_gypfiles/v8_compiler.target.mk:379: /home/riscv-builds/runner_dir/workspace/cloud-v-builds-folder/node-riscv-build/node/out/Release/obj.target/v8_compiler/deps/v8/src/maglev/maglev-ir.o] Error 1
make[1]: *** [tools/v8_gypfiles/v8_compiler.target.mk:379: /home/riscv-builds/runner_dir/workspace/cloud-v-builds-folder/node-riscv-build/node/out/Release/obj.target/v8_compiler/deps/v8/src/compiler/backend/instruction-selector.o] Error 1
rm 34a4c6057edee8594d60d6f57a7a30ec5d3de25b.intermediate 4f132d24141093a0f4a73ab5729e1f13b0f9eb30.intermediate 34cb89d13cb038fbc7b4135d2a1a14390e770f3f.intermediate
make: *** [Makefile:135: node] Error 2

Additional information

I have set up regular nightly builds for many opensource packages for riscv64 architecture as I have a lot of RISC-V compute instances in the Cloud-V.

I have added nodejs. Previously it was working fine without any issues but now it is throwing errors. My guess is that it is related to v8 but I don't see any requirement anywhere in the documentation about the dependencies of v8.

[bnoordhuis]

What version of gcc or clang is that?

[alitariq4589]

What version of gcc or clang is that?

GCC Version:

gcc (Debian 14.2.0-19) 14.2.0

clang version:

Debian clang version 19.1.7 (3)
Target: riscv64-unknown-linux-gnu
Thread model: posix

[bnoordhuis]

You're compiling with gcc, right? Is it an option for you to try with gcc 12 or clang? The build error could be either because of a gcc bug or because something broke in V8's riscv build, but I can't say for sure what.

I'm leaning towards gcc bug because gcc has had trouble parsing that particular construct in the past, but again, I can't say for sure.

[alitariq4589]

I can build GCC 12 for this and then change the script to use gcc version 12 for building Node.js, but I don't think this will be maintainable in the long run.

Anyways, I will try and see if it works. Thanks for the idea.

[alitariq4589]

I'm leaning towards gcc bug because gcc has had trouble parsing that particular construct in the past, but again, I can't say for sure

Changing the GCC version to 12 did not resolve the issue and I am getting the same error. The complete log can be check at this link

[kxxt]

Duplicate of #58485