Skip to content

dns: move falsy hostname in lookup to end-of-life #58619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2025
Merged

dns: move falsy hostname in lookup to end-of-life #58619

merged 1 commit into from
Jun 13, 2025

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jun 7, 2025

It's been deprecated for ~7 years. It's time.

@jasnell jasnell requested review from mcollina, anonrig and BridgeAR June 7, 2025 15:27
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added dns Issues and PRs related to the dns subsystem. needs-ci PRs that need a full CI run. labels Jun 7, 2025
@jasnell jasnell added semver-major PRs that contain breaking changes and should be released in the next major version. deprecations Issues and PRs related to deprecations. labels Jun 7, 2025
jasnell
jasnell commented Jun 7, 2025
View reviewed changes
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@codecov Codecov
Copy link

codecov bot commented Jun 7, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.14%. Comparing base (3c351c2) to head (30b44f5).
Report is 43 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58619      +/-   ##
==========================================
+ Coverage   90.13%   90.14%   +0.01%     
==========================================
  Files         636      637       +1     
  Lines      187891   188002     +111     
  Branches    36878    36877       -1     
==========================================
+ Hits       169348   169469     +121     
+ Misses      11289    11276      -13     
- Partials     7254     7257       +3
Files with missing lines Coverage Δ
lib/dns.js 98.64% <100.00%> (-0.03%) ⬇️
lib/internal/dns/promises.js 98.29% <100.00%> (-0.01%) ⬇️
lib/internal/dns/utils.js 99.42% <ø> (-0.03%) ⬇️

... and 48 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell jasnell force-pushed the jasnell/eol-dns-lookup-falsy branch from 421c796 to 966e068 Compare June 8, 2025 15:59
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 8, 2025 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/67336/ 💛

@lpinca
Copy link
Member

lpinca commented Jun 9, 2025

test/internet/test-dns.js needs fixes.

@jasnell
Copy link
Member Author

jasnell commented Jun 13, 2025

@nodejs/tsc please :-)

@jasnell
dns: move falsy hostname in lookup to end-of-life
30b44f5 
It's been deprecated for ~7 years. It's time.
@jasnell jasnell force-pushed the jasnell/eol-dns-lookup-falsy branch from 966e068 to 30b44f5 Compare June 13, 2025 00:14
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67428/

@jasnell jasnell added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jun 13, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 13, 2025
@nodejs-github-bot nodejs-github-bot merged commit a5f9ca1 into nodejs:main Jun 13, 2025
61 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a5f9ca1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panva panva panva approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@bjohansebas bjohansebas bjohansebas approved these changes

@mcollina mcollina Awaiting requested review from mcollina

@BridgeAR BridgeAR Awaiting requested review from BridgeAR

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. deprecations Issues and PRs related to deprecations. dns Issues and PRs related to the dns subsystem. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jasnell @nodejs-github-bot @lpinca @panva @anonrig @bjohansebas