Skip to content

tools: edit commit-queue workflow file #58667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Jun 10, 2025

With nodejs/node-core-utils#918, we no longer need to preemptively fetch the full history. There are also a bunch of nits to make the code more consistent with the rest of the code base.

Tested with https://github.com/nodejs/node-auto-test/actions/runs/15568681251

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jun 10, 2025
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@LiviaMedeiros LiviaMedeiros added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 11, 2025
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 12, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 12, 2025
@nodejs-github-bot nodejs-github-bot merged commit efd28a0 into nodejs:main Jun 12, 2025
25 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in efd28a0

@aduh95 aduh95 deleted the cq-shallow-fetch branch June 12, 2025 21:41
targos pushed a commit that referenced this pull request Jun 16, 2025
PR-URL: #58667
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants