[v22.x backport] esm: implement import.meta.main #58693
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
lib / src
Lordfirespeed
changed the title
|
Should include #58661 if it doesn't already |
|
We should only pick the commits that have landed on |
|
Ah, my bad, I probably picked commits from the wrong branch. |
Boolean value to check if an ES Module is the entrypoint of the current process. Implements: nodejs#57226 Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: nodejs#57804 Fixes: nodejs#57226 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> (cherry picked from commit bbc0593)
PR-URL: nodejs#58661 Fixes: nodejs#58660 Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> (cherry picked from commit bba07d7)
`phase` parameter doesn't exist in v22.x
Lordfirespeed
force-pushed
the
backport-import-meta-main-to-v22.x
branch
from
e529a26 to
8868f38
Compare
|
@aduh95 to adhere to the 'only commits that landed' rule, should I squash the new commits into a landed commit? or are commits for manual resolution after cherry-picking OK? |
|
What's the deal here? I don't understand why CI is failing 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #57804 to v22.x release line