-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
New SQlite database options #58697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
New SQlite database options #58697
Conversation
Review requested:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58697 +/- ##
==========================================
+ Coverage 90.03% 90.11% +0.07%
==========================================
Files 635 639 +4
Lines 187688 188262 +574
Branches 36761 36924 +163
==========================================
+ Hits 168991 169654 +663
+ Misses 11499 11326 -173
- Partials 7198 7282 +84
🚀 New features to boost your workflow:
|
I'm wrong |
There are a few tests I think we don't need because they are redundant, e.g., those that handle the default scenario. Here, for example, the default is Other than that, I think you addressed the left comments as expected. Thank you. I will just ping @nodejs/cpp-reviewers to get a more experienced C++ review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cpp code LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggested changes are optional.
Co-authored-by: Rafael Gonzaga <rafael.nunu@hotmail.com>
Co-authored-by: Daniel Lemire <daniel@lemire.me>
This introduces new SQLite database options that can be set at the database connection level.
cc @geeksilva97