Skip to content

New SQlite database options #58697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

miguelmarcondesf
Copy link
Contributor

@miguelmarcondesf miguelmarcondesf commented Jun 12, 2025

This introduces new SQLite database options that can be set at the database connection level.

cc @geeksilva97

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/sqlite

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jun 12, 2025
@miguelmarcondesf miguelmarcondesf marked this pull request as ready for review June 13, 2025 11:29
Copy link

codecov bot commented Jun 13, 2025

Codecov Report

Attention: Patch coverage is 94.59459% with 4 lines in your changes missing coverage. Please review.

Project coverage is 90.11%. Comparing base (5457443) to head (5693d3c).
Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sqlite.cc 92.00% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58697      +/-   ##
==========================================
+ Coverage   90.03%   90.11%   +0.07%     
==========================================
  Files         635      639       +4     
  Lines      187688   188262     +574     
  Branches    36761    36924     +163     
==========================================
+ Hits       168991   169654     +663     
+ Misses      11499    11326     -173     
- Partials     7198     7282      +84     
Files with missing lines Coverage Δ
src/node_sqlite.h 83.67% <100.00%> (+15.67%) ⬆️
src/node_sqlite.cc 81.06% <92.00%> (+0.26%) ⬆️

... and 78 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@geeksilva97
Copy link
Contributor

geeksilva97 commented Jun 17, 2025

Since it's addressing a TODO comment, you need to remove it from the code. I was unable to see it

I'm wrong

@geeksilva97 geeksilva97 added the sqlite Issues and PRs related to the SQLite subsystem. label Jun 18, 2025
@geeksilva97
Copy link
Contributor

There are a few tests I think we don't need because they are redundant, e.g., those that handle the default scenario. Here, for example, the default is false already, which is already covered.

Other than that, I think you addressed the left comments as expected. Thank you.

I will just ping @nodejs/cpp-reviewers to get a more experienced C++ review.

@RafaelGSS RafaelGSS added semver-minor PRs that contain new features and should be released in the next minor version. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jun 18, 2025
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cpp code LGTM.

Copy link
Member

@lemire lemire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggested changes are optional.

miguelmarcondesf and others added 2 commits June 18, 2025 12:28
Co-authored-by: Rafael Gonzaga <rafael.nunu@hotmail.com>
miguelmarcondesf and others added 2 commits June 18, 2025 12:37
Co-authored-by: Daniel Lemire <daniel@lemire.me>
@geeksilva97 geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 18, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 18, 2025
@nodejs-github-bot
Copy link
Collaborator

@geeksilva97 geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2025
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version. sqlite Issues and PRs related to the SQLite subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants