-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
src: unflag --experimental-default-config-file #58703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
src: unflag --experimental-default-config-file #58703
Conversation
Review requested:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58703 +/- ##
==========================================
- Coverage 90.17% 90.13% -0.04%
==========================================
Files 637 637
Lines 188023 187999 -24
Branches 36887 36878 -9
==========================================
- Hits 169552 169461 -91
- Misses 11223 11286 +63
- Partials 7248 7252 +4
🚀 New features to boost your workflow:
|
f664b7b
to
76d618d
Compare
doc/api/cli.md
Outdated
@@ -990,7 +990,7 @@ added: | |||
|
|||
> Stability: 1.0 - Early development | |||
|
|||
If the `--experimental-default-config-file` flag is present, Node.js will look for a | |||
Unless `--no-experimental-default-config-file` flag is present, Node.js will look for a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still an experimental feature (line 991). What's the goal of this change? We should also make it stable at the same time, or not enable it this early.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why make it stable? It's still experimental but people can start using it with a nice dx, so that node automatically picks up node.config.json without the flag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it make more sense to stabilize this feature before enabling it by default?
- Stabilize the default config file (remove the --experimental)
- Enable it by default
To answer both @RafaelGSS and @anonrig it does not make sense to stabilize and then unflag because similarly to |
76d618d
to
6043c63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should unflag this while having the config file as an experimental feature.
There is no way it can become stable before being unflagged as I explained above. @nodejs/tsc |
I won’t be too strong about this, but that’s usually how it works for most experimental flags we introduce—for example, the Permission Model. If we enable an experimental feature by default before addressing all the necessary security patches (while the feature is still opt-in and experimental), it feels a bit odd and too risky in my opinion. Some features just need more time for people to adopt and test. Forcing them (or enabling by default) feels like pushing it too much, IMO. |
Let's unflag it in Node.js v25