-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
process: move multipleResolves event to EOL #58707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
The `multipleResolves` event has been deprecated for several years now. It's time.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58707 +/- ##
==========================================
- Coverage 90.15% 90.13% -0.03%
==========================================
Files 637 637
Lines 188122 188062 -60
Branches 36886 36892 +6
==========================================
- Hits 169595 169502 -93
- Misses 11271 11317 +46
+ Partials 7256 7243 -13
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not blocking but IMHO this event should get Legacy
status rather than being removed. Or we can keep it forever runtime deprecated (similar to how DEP0174
works) and make the warning message more descriptive.
Despite the false positives with Promise.race
and Promise.all
, it still can be useful for locating problems where code unintentionally keeps flowing after calling resolve()
or reject()
.
If keeping this causes noticeable runtime overhead even when there's no listener (judging from this PR, it's just one boolean check per fired event?), +0 solely for performance reasons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -3327,6 +3327,9 @@ the errors used for value type validation. | |||
|
|||
<!-- YAML | |||
changes: | |||
- version: REPLACEME | |||
pr-url: https://github.com/nodejs/node/pull/00000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pr-url: https://github.com/nodejs/node/pull/00000 | |
pr-url: https://github.com/nodejs/node/pull/58707 |
|
||
This event was deprecated because it did not work with V8 promise combinators | ||
which diminished its usefulness. | ||
This event was deprecated and remove because it did not work with V8 promise |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This event was deprecated and remove because it did not work with V8 promise | |
This event was deprecated and removed because it did not work with V8 promise |
The
multipleResolves
event has been deprecated for several years now. It's time.