Skip to content

lib: remove globalPreload support #58743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kazuma0129
Copy link
Contributor

Resolved TODO left at #49144.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. labels Jun 17, 2025
Since the loader is now stable, the warning when using globalPreload is
no longer necessary.
The globalPreload warning is no longer emitted, so the related test is
removed.
@kazuma0129 kazuma0129 force-pushed the kazuma0129-patch-1 branch from 970c7e7 to f777eab Compare June 17, 2025 16:44
Copy link

codecov bot commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.12%. Comparing base (462c741) to head (f777eab).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58743      +/-   ##
==========================================
- Coverage   90.15%   90.12%   -0.04%     
==========================================
  Files         639      639              
  Lines      188201   188185      -16     
  Branches    36915    36914       -1     
==========================================
- Hits       169675   169601      -74     
- Misses      11274    11316      +42     
- Partials     7252     7268      +16     
Files with missing lines Coverage Δ
lib/internal/modules/esm/hooks.js 90.55% <ø> (-0.13%) ⬇️

... and 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added semver-major PRs that contain breaking changes and should be released in the next major version. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 18, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 18, 2025
@nodejs-github-bot
Copy link
Collaborator

Copy link
Member

@JakobJingleheimer JakobJingleheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loaders aren't stable, but I think it's been enough time to remove.

In an abundance of caution though, perhaps let's mark this major?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants