Skip to content

src: pass resource on permission checks for spawn #58758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2025
Merged

src: pass resource on permission checks for spawn #58758

merged 1 commit into from
Jun 21, 2025
+40 −18

Conversation

RafaelGSS
Copy link
Member

src: pass resource on permission checks for spawn

This commit enhances the permission model errors
when no --allow-child-process is used and the error is emitted.

@RafaelGSS RafaelGSS added the permission Issues and PRs related to the Permission Model label Jun 18, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jun 18, 2025
geeksilva97
geeksilva97 reviewed Jun 18, 2025
View reviewed changes
geeksilva97
geeksilva97 reviewed Jun 18, 2025
View reviewed changes
@RafaelGSS
src: pass resource on permission checks for spawn
c1ed638 
This commit enhances the permission model errors
when no --allow-child-process is used and the error
is emitted.

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@RafaelGSS RafaelGSS force-pushed the enable-resource-pm-child-process branch from 1f9aeef to c1ed638 Compare June 18, 2025 20:28
@codecov Codecov
Copy link

codecov bot commented Jun 18, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 90.12%. Comparing base (f2e99c5) to head (c1ed638).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/process_wrap.cc 57.14% 1 Missing and 2 partials ⚠️
src/spawn_sync.cc 75.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58758      +/-   ##
==========================================
+ Coverage   90.02%   90.12%   +0.10%     
==========================================
  Files         639      639              
  Lines      188173   188204      +31     
  Branches    36831    36910      +79     
==========================================
+ Hits       169404   169624     +220     
+ Misses      11509    11325     -184     
+ Partials     7260     7255       -5
Files with missing lines Coverage Δ
src/node_process_methods.cc 87.85% <100.00%> (ø)
src/process_wrap.cc 66.66% <57.14%> (ø)
src/spawn_sync.cc 68.68% <75.00%> (+0.10%) ⬆️

... and 40 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RafaelGSS RafaelGSS added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 19, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67530/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67570/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67579/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 21, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 21, 2025
@nodejs-github-bot nodejs-github-bot merged commit b04c4a4 into nodejs:main Jun 21, 2025
64 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in b04c4a4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@geeksilva97 geeksilva97 geeksilva97 approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@bjohansebas bjohansebas bjohansebas approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@RafaelGSS @nodejs-github-bot @anonrig @geeksilva97 @marco-ippolito @bjohansebas @aduh95