Skip to content

[v20.x] test: skip broken sea on rhel8 #58761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[v20.x] test: skip broken sea on rhel8 #58761

wants to merge 1 commit into from
+12 −0

Conversation

marco-ippolito
Copy link
Member

Refs: #58588

Should unblock the v20 release

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Jun 19, 2025
@marco-ippolito marco-ippolito changed the title test: skip broken sea on rhel8 [v20.x] test: skip broken sea on rhel8 Jun 19, 2025
@panva panva mentioned this pull request Jun 19, 2025
Open
@panva panva added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @panva. Please 👍 to approve.

RaisinTen
RaisinTen reviewed Jun 19, 2025
View reviewed changes
mcollina
mcollina approved these changes Jun 19, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67532/

mhdawson
mhdawson approved these changes Jun 19, 2025
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67538/

marco-ippolito added a commit that referenced this pull request Jun 20, 2025
@marco-ippolito
test: skip broken sea on rhel8
850192b 
PR-URL: #58761
Refs: #58588
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
@marco-ippolito
Copy link
Member Author

Landed in 850192b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@panva panva panva approved these changes

@anonrig anonrig anonrig approved these changes

@richardlau richardlau richardlau approved these changes

@mhdawson mhdawson mhdawson approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@joyeecheung joyeecheung Awaiting requested review from joyeecheung

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. v20.x v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@marco-ippolito @nodejs-github-bot @mcollina @panva @anonrig @richardlau @mhdawson @RaisinTen