Skip to content

lib: make validateInternalField() throw ERR_INVALID_THIS #58765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

LiviaMedeiros
Copy link
Member

internal/validators.validateInternalField() has no other purpose than to validate this value.
It must throw ERR_INVALID_THIS rather than ERR_INVALID_ARG_TYPE, and ideally have more appropriate name (used validateThisInternalField).

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jun 19, 2025
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

Attention: Patch coverage is 98.73418% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.12%. Comparing base (5584cc5) to head (4cba46d).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/perf/performance_entry.js 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58765      +/-   ##
==========================================
- Coverage   90.13%   90.12%   -0.02%     
==========================================
  Files         639      639              
  Lines      188192   188199       +7     
  Branches    36916    36916              
==========================================
- Hits       169633   169617      -16     
+ Misses      11324    11322       -2     
- Partials     7235     7260      +25     
Files with missing lines Coverage Δ
lib/internal/errors.js 97.50% <100.00%> (ø)
lib/internal/event_target.js 99.15% <100.00%> (ø)
lib/internal/perf/observe.js 91.55% <100.00%> (ø)
lib/internal/perf/performance.js 93.49% <100.00%> (ø)
lib/internal/perf/resource_timing.js 99.62% <100.00%> (ø)
lib/internal/perf/usertiming.js 94.14% <100.00%> (ø)
lib/internal/validators.js 98.16% <100.00%> (+0.01%) ⬆️
lib/internal/vm/module.js 98.31% <100.00%> (ø)
lib/internal/perf/performance_entry.js 90.00% <87.50%> (ø)

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 19, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants