Skip to content

[pass] Add CSE #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Jun 2, 2025
Merged

[pass] Add CSE #36

merged 24 commits into from
Jun 2, 2025

Conversation

titaiwangms
Copy link
Collaborator

@titaiwangms titaiwangms requested a review from justinchuby May 30, 2025 16:45
@titaiwangms titaiwangms requested a review from a team as a code owner May 30, 2025 16:45
Copy link

codecov bot commented May 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.59%. Comparing base (322205f) to head (3002e3b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #36      +/-   ##
==========================================
+ Coverage   73.06%   73.59%   +0.53%     
==========================================
  Files          36       37       +1     
  Lines        4433     4492      +59     
  Branches      891      902      +11     
==========================================
+ Hits         3239     3306      +67     
+ Misses        863      858       -5     
+ Partials      331      328       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinchuby
Copy link
Member

justinchuby commented May 30, 2025

You can add onnxruntime in COMMON_TEST_DEPENDENCIES https://github.com/onnx/ir-py/blob/main/noxfile.py

@justinchuby
Copy link
Member

onnxscript can be installed with --no-deps

@justinchuby
Copy link
Member

The reuse check needs to be fixed

Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
@titaiwangms titaiwangms added the do not merge Do not merge yet label May 30, 2025
@justinchuby justinchuby added do not merge Do not merge yet and removed do not merge Do not merge yet labels May 30, 2025
@titaiwangms titaiwangms requested a review from gramalingam June 2, 2025 21:42
@justinchuby justinchuby added this to the 0.1.1 milestone Jun 2, 2025
@titaiwangms titaiwangms removed the do not merge Do not merge yet label Jun 2, 2025
Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
justinchuby and others added 16 commits June 2, 2025 22:58
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
…t.py

Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
Previously it was called "test", which is too generic to make required.

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
According to
https://github.com/googleapis/repo-automation-bots/tree/main/packages/do-not-merge#configuration.
So when a PR is tagged do not merge it will not be merged accidentally

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
Revert changes to LiftConstantsToInitializersPass because I realized
even without variable shadowing, two subgraphs can still define
initializers that have the same names in their respective naming scopes.
A conflict resolution logic is still needed to ensure initializers
coming from different subgraphs do not collide. So I reverted my
changes.

---------

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
Update after release.

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
Bumps [ruff](https://github.com/astral-sh/ruff) from 0.11.11 to 0.11.12.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/astral-sh/ruff/releases">ruff's
releases</a>.</em></p>
<blockquote>
<h2>0.11.12</h2>
<h2>Release Notes</h2>
<h3>Preview features</h3>
<ul>
<li>[<code>airflow</code>] Revise fix titles (<code>AIR3</code>) (<a
href="https://redirect.github.com/astral-sh/ruff/pull/18215">#18215</a>)</li>
<li>[<code>pylint</code>] Implement <code>missing-maxsplit-arg</code>
(<code>PLC0207</code>) (<a
href="https://redirect.github.com/astral-sh/ruff/pull/17454">#17454</a>)</li>
<li>[<code>pyupgrade</code>] New rule <code>UP050</code>
(<code>useless-class-metaclass-type</code>) (<a
href="https://redirect.github.com/astral-sh/ruff/pull/18334">#18334</a>)</li>
<li>[<code>flake8-use-pathlib</code>] Replace <code>os.symlink</code>
with <code>Path.symlink_to</code> (<code>PTH211</code>) (<a
href="https://redirect.github.com/astral-sh/ruff/pull/18337">#18337</a>)</li>
</ul>
<h3>Bug fixes</h3>
<ul>
<li>[<code>flake8-bugbear</code>] Ignore <code>__debug__</code>
attribute in <code>B010</code> (<a
href="https://redirect.github.com/astral-sh/ruff/pull/18357">#18357</a>)</li>
<li>[<code>flake8-async</code>] Fix <code>anyio.sleep</code> argument
name (<code>ASYNC115</code>, <code>ASYNC116</code>) (<a
href="https://redirect.github.com/astral-sh/ruff/pull/18262">#18262</a>)</li>
<li>[<code>refurb</code>] Fix <code>FURB129</code> autofix generating
invalid syntax (<a
href="https://redirect.github.com/astral-sh/ruff/pull/18235">#18235</a>)</li>
</ul>
<h3>Rule changes</h3>
<ul>
<li>[<code>flake8-implicit-str-concat</code>] Add autofix for
<code>ISC003</code> (<a
href="https://redirect.github.com/astral-sh/ruff/pull/18256">#18256</a>)</li>
<li>[<code>pycodestyle</code>] Improve the diagnostic message for
<code>E712</code> (<a
href="https://redirect.github.com/astral-sh/ruff/pull/18328">#18328</a>)</li>
<li>[<code>flake8-2020</code>] Fix diagnostic message for
<code>!=</code> comparisons (<code>YTT201</code>) (<a
href="https://redirect.github.com/astral-sh/ruff/pull/18293">#18293</a>)</li>
<li>[<code>pyupgrade</code>] Make fix unsafe if it deletes comments
(<code>UP010</code>) (<a
href="https://redirect.github.com/astral-sh/ruff/pull/18291">#18291</a>)</li>
</ul>
<h3>Documentation</h3>
<ul>
<li>Simplify rules table to improve readability (<a
href="https://redirect.github.com/astral-sh/ruff/pull/18297">#18297</a>)</li>
<li>Update editor integrations link in README (<a
href="https://redirect.github.com/astral-sh/ruff/pull/17977">#17977</a>)</li>
<li>[<code>flake8-bugbear</code>] Add fix safety section
(<code>B006</code>) (<a
href="https://redirect.github.com/astral-sh/ruff/pull/17652">#17652</a>)</li>
</ul>
<h2>Contributors</h2>
<ul>
<li><a
href="https://github.com/AlexWaygood"><code>@​AlexWaygood</code></a></li>
<li><a
href="https://github.com/CodeMan62"><code>@​CodeMan62</code></a></li>
<li><a
href="https://github.com/InSyncWithFoo"><code>@​InSyncWithFoo</code></a></li>
<li><a
href="https://github.com/Kalmaegi"><code>@​Kalmaegi</code></a></li>
<li><a
href="https://github.com/LaBatata101"><code>@​LaBatata101</code></a></li>
<li><a href="https://github.com/Lee-W"><code>@​Lee-W</code></a></li>
<li><a
href="https://github.com/MaddyGuthridge"><code>@​MaddyGuthridge</code></a></li>
<li><a
href="https://github.com/MatthewMckee4"><code>@​MatthewMckee4</code></a></li>
<li><a
href="https://github.com/MichaReiser"><code>@​MichaReiser</code></a></li>
<li><a
href="https://github.com/Vasanth-96"><code>@​Vasanth-96</code></a></li>
<li><a href="https://github.com/carljm"><code>@​carljm</code></a></li>
<li><a
href="https://github.com/charliermarsh"><code>@​charliermarsh</code></a></li>
<li><a
href="https://github.com/chirizxc"><code>@​chirizxc</code></a></li>
<li><a
href="https://github.com/dcreager"><code>@​dcreager</code></a></li>
<li><a
href="https://github.com/dhruvmanila"><code>@​dhruvmanila</code></a></li>
<li><a
href="https://github.com/dsherret"><code>@​dsherret</code></a></li>
<li><a href="https://github.com/dylwil3"><code>@​dylwil3</code></a></li>
<li><a
href="https://github.com/felixscherz"><code>@​felixscherz</code></a></li>
<li><a href="https://github.com/fennr"><code>@​fennr</code></a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md">ruff's
changelog</a>.</em></p>
<blockquote>
<h2>0.11.12</h2>
<h3>Preview features</h3>
<ul>
<li>[<code>airflow</code>] Revise fix titles (<code>AIR3</code>) (<a
href="https://redirect.github.com/astral-sh/ruff/pull/18215">#18215</a>)</li>
<li>[<code>pylint</code>] Implement <code>missing-maxsplit-arg</code>
(<code>PLC0207</code>) (<a
href="https://redirect.github.com/astral-sh/ruff/pull/17454">#17454</a>)</li>
<li>[<code>pyupgrade</code>] New rule <code>UP050</code>
(<code>useless-class-metaclass-type</code>) (<a
href="https://redirect.github.com/astral-sh/ruff/pull/18334">#18334</a>)</li>
<li>[<code>flake8-use-pathlib</code>] Replace <code>os.symlink</code>
with <code>Path.symlink_to</code> (<code>PTH211</code>) (<a
href="https://redirect.github.com/astral-sh/ruff/pull/18337">#18337</a>)</li>
</ul>
<h3>Bug fixes</h3>
<ul>
<li>[<code>flake8-bugbear</code>] Ignore <code>__debug__</code>
attribute in <code>B010</code> (<a
href="https://redirect.github.com/astral-sh/ruff/pull/18357">#18357</a>)</li>
<li>[<code>flake8-async</code>] Fix <code>anyio.sleep</code> argument
name (<code>ASYNC115</code>, <code>ASYNC116</code>) (<a
href="https://redirect.github.com/astral-sh/ruff/pull/18262">#18262</a>)</li>
<li>[<code>refurb</code>] Fix <code>FURB129</code> autofix generating
invalid syntax (<a
href="https://redirect.github.com/astral-sh/ruff/pull/18235">#18235</a>)</li>
</ul>
<h3>Rule changes</h3>
<ul>
<li>[<code>flake8-implicit-str-concat</code>] Add autofix for
<code>ISC003</code> (<a
href="https://redirect.github.com/astral-sh/ruff/pull/18256">#18256</a>)</li>
<li>[<code>pycodestyle</code>] Improve the diagnostic message for
<code>E712</code> (<a
href="https://redirect.github.com/astral-sh/ruff/pull/18328">#18328</a>)</li>
<li>[<code>flake8-2020</code>] Fix diagnostic message for
<code>!=</code> comparisons (<code>YTT201</code>) (<a
href="https://redirect.github.com/astral-sh/ruff/pull/18293">#18293</a>)</li>
<li>[<code>pyupgrade</code>] Make fix unsafe if it deletes comments
(<code>UP010</code>) (<a
href="https://redirect.github.com/astral-sh/ruff/pull/18291">#18291</a>)</li>
</ul>
<h3>Documentation</h3>
<ul>
<li>Simplify rules table to improve readability (<a
href="https://redirect.github.com/astral-sh/ruff/pull/18297">#18297</a>)</li>
<li>Update editor integrations link in README (<a
href="https://redirect.github.com/astral-sh/ruff/pull/17977">#17977</a>)</li>
<li>[<code>flake8-bugbear</code>] Add fix safety section
(<code>B006</code>) (<a
href="https://redirect.github.com/astral-sh/ruff/pull/17652">#17652</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/astral-sh/ruff/commit/aee3af0f7a018e9fcf921b746ad8ef76d3b84b83"><code>aee3af0</code></a>
Bump 0.11.12 (<a
href="https://redirect.github.com/astral-sh/ruff/issues/18369">#18369</a>)</li>
<li><a
href="https://github.com/astral-sh/ruff/commit/04dc48e17c2518f97436d76284a509499087d81c"><code>04dc48e</code></a>
[<code>refurb</code>] Fix <code>FURB129</code> autofix generating
invalid syntax (<a
href="https://redirect.github.com/astral-sh/ruff/issues/18235">#18235</a>)</li>
<li><a
href="https://github.com/astral-sh/ruff/commit/27743efa1bbcb8952faf1b85c2f439694c24ce1f"><code>27743ef</code></a>
[<code>pylint</code>] Implement <code>missing-maxsplit-arg</code>
(<code>PLC0207</code>) (<a
href="https://redirect.github.com/astral-sh/ruff/issues/17454">#17454</a>)</li>
<li><a
href="https://github.com/astral-sh/ruff/commit/c60b4d7f309918ac4e98b805fcac5a26e6925899"><code>c60b4d7</code></a>
[ty] Add subtyping between Callable types and class literals with
<code>__init__</code> ...</li>
<li><a
href="https://github.com/astral-sh/ruff/commit/16621fa19df6986c80a8d2d0c7e6d97740380d2c"><code>16621fa</code></a>
[<code>flake8-bugbear </code>] Add fix safety section
(<code>B006</code>) (<a
href="https://redirect.github.com/astral-sh/ruff/issues/17652">#17652</a>)</li>
<li><a
href="https://github.com/astral-sh/ruff/commit/e23d4ea027ecbc05213d049ac6dfcf726f4ab167"><code>e23d4ea</code></a>
[<code>flake8-bugbear</code>] Ignore <code>__debug__</code> attribute in
<code>B010</code> (<a
href="https://redirect.github.com/astral-sh/ruff/issues/18357">#18357</a>)</li>
<li><a
href="https://github.com/astral-sh/ruff/commit/452f992fbc4f48866c40c4b312806b8876958fa0"><code>452f992</code></a>
[ty] Simplify signature types, use them in <code>CallableType</code> (<a
href="https://redirect.github.com/astral-sh/ruff/issues/18344">#18344</a>)</li>
<li><a
href="https://github.com/astral-sh/ruff/commit/a5ebb3f3a2b347849d0c195884ea944fb690b187"><code>a5ebb3f</code></a>
[ty] Support ephemeral uv virtual environments (<a
href="https://redirect.github.com/astral-sh/ruff/issues/18335">#18335</a>)</li>
<li><a
href="https://github.com/astral-sh/ruff/commit/9925910a29643ff1f29eafeadc2b1d26812e4993"><code>9925910</code></a>
Add a <code>ViolationMetadata::rule</code> method (<a
href="https://redirect.github.com/astral-sh/ruff/issues/18234">#18234</a>)</li>
<li><a
href="https://github.com/astral-sh/ruff/commit/a3ee6bb3b5f4f375e606d3bc12094549bb46a98b"><code>a3ee6bb</code></a>
Return <code>DiagnosticGuard</code> from
<code>Checker::report_diagnostic</code> (<a
href="https://redirect.github.com/astral-sh/ruff/issues/18232">#18232</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/astral-sh/ruff/compare/0.11.11...0.11.12">compare
view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ruff&package-manager=pip&previous-version=0.11.11&new-version=0.11.12)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)

</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
Bumps [mypy](https://github.com/python/mypy) from 1.15.0 to 1.16.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/python/mypy/blob/master/CHANGELOG.md">mypy's
changelog</a>.</em></p>
<blockquote>
<h1>Mypy Release Notes</h1>
<h2>Next Release</h2>
<h2>Mypy 1.16</h2>
<p>We’ve just uploaded mypy 1.16 to the Python Package Index (<a
href="https://pypi.org/project/mypy/">PyPI</a>).
Mypy is a static type checker for Python. This release includes new
features and bug fixes.
You can install it as follows:</p>
<pre><code>python3 -m pip install -U mypy
</code></pre>
<p>You can read the full documentation for this release on <a
href="http://mypy.readthedocs.io">Read the Docs</a>.</p>
<h3>Different Property Getter and Setter Types</h3>
<p>Mypy now supports using different types for a property getter and
setter:</p>
<pre lang="python"><code>class A:
    _value: int
<pre><code>@Property
def foo(self) -&amp;gt; int:
    return self._value

@foo.setter
def foo(self, x: str | int) -&amp;gt; None:
    try:
        self._value = int(x)
    except ValueError:
raise Exception(f&amp;quot;'{x}' is not a valid value for
'foo'&amp;quot;)
</code></pre>
<p></code></pre></p>
<p>This was contributed by Ivan Levkivskyi (PR <a
href="https://redirect.github.com/python/mypy/pull/18510">18510</a>).</p>
<h3>Flexible Variable Redefinitions (Experimental)</h3>
<p>Mypy now allows unannotated variables to be freely redefined with
different types when using the experimental
<code>--allow-redefinition-new</code>
flag. You will also need to enable <code>--local-partial-types</code>.
Mypy will
now infer a union type when different types are assigned to a
variable:</p>
<pre lang="py"><code># mypy: allow-redefinition-new, local-partial-types
<p>def f(n: int, b: bool) -&gt; int | str:
if b:
x = n
else:
&lt;/tr&gt;&lt;/table&gt;
</code></pre></p>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/python/mypy/commit/9e72e9601f4c2fb6866cfec98fc40a31c91ccdb0"><code>9e72e96</code></a>
Update version to 1.16.0</li>
<li><a
href="https://github.com/python/mypy/commit/8fe719ff3a8d1e26d3841a48df21ddf7d5b3c94d"><code>8fe719f</code></a>
Add changelog for 1.16 (<a
href="https://redirect.github.com/python/mypy/issues/19138">#19138</a>)</li>
<li><a
href="https://github.com/python/mypy/commit/2a036e739f8691576056669371d9f020e95c2603"><code>2a036e7</code></a>
Revert &quot;Infer correct types with overloads of <code>Type[Guard |
Is]</code> (<a
href="https://redirect.github.com/python/mypy/issues/19161">#19161</a>)</li>
<li><a
href="https://github.com/python/mypy/commit/b6da4fcf97fca9cd28e81a880f818dc364b5a06d"><code>b6da4fc</code></a>
Allow enum members to have type objects as values (<a
href="https://redirect.github.com/python/mypy/issues/19160">#19160</a>)</li>
<li><a
href="https://github.com/python/mypy/commit/334469f999c5c777124a123062b4349614447e0d"><code>334469f</code></a>
[mypyc] Improve documentation of native and non-native classes (<a
href="https://redirect.github.com/python/mypy/issues/19154">#19154</a>)</li>
<li><a
href="https://github.com/python/mypy/commit/a499d9fdba06732248c07586f2fd95c47a4fa0f7"><code>a499d9f</code></a>
Document --allow-redefinition-new (<a
href="https://redirect.github.com/python/mypy/issues/19153">#19153</a>)</li>
<li><a
href="https://github.com/python/mypy/commit/96525a23f0f8a3826d9875fa8b6e8e362cd9525e"><code>96525a2</code></a>
Merge commit '9e45dadcf6d8dbab36f83d9df94a706c0b4f9207' into
release-1.16</li>
<li><a
href="https://github.com/python/mypy/commit/9e45dadcf6d8dbab36f83d9df94a706c0b4f9207"><code>9e45dad</code></a>
Clear more data in TypeChecker.reset() instead of asserting (<a
href="https://redirect.github.com/python/mypy/issues/19087">#19087</a>)</li>
<li><a
href="https://github.com/python/mypy/commit/772cd0cebed6884636de0019e43caa06dbaa39ba"><code>772cd0c</code></a>
Add --strict-bytes to --strict (<a
href="https://redirect.github.com/python/mypy/issues/19049">#19049</a>)</li>
<li><a
href="https://github.com/python/mypy/commit/0b65f215996401264a68a3a06f3fbcd19915a9a5"><code>0b65f21</code></a>
Admit that Final variables are never redefined (<a
href="https://redirect.github.com/python/mypy/issues/19083">#19083</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/python/mypy/compare/v1.15.0...v1.16.0">compare
view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=mypy&package-manager=pip&previous-version=1.15.0&new-version=1.16.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)

</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action)
from 2.4.1 to 2.4.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/ossf/scorecard-action/releases">ossf/scorecard-action's
releases</a>.</em></p>
<blockquote>
<h2>v2.4.2</h2>
<h2>What's Changed</h2>
<p>This update bumps the Scorecard version to the v5.2.1 release. For a
complete list of changes, please refer to the Scorecard <a
href="https://github.com/ossf/scorecard/releases/tag/v5.2.0">v5.2.0</a>
and <a
href="https://github.com/ossf/scorecard/releases/tag/v5.2.1">v5.2.1</a>
release notes.</p>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/ossf/scorecard-action/compare/v2.4.1...v2.4.2">https://github.com/ossf/scorecard-action/compare/v2.4.1...v2.4.2</a></p>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/ossf/scorecard-action/commit/05b42c624433fc40578a4040d5cf5e36ddca8cde"><code>05b42c6</code></a>
:seedling: bump docker to ghcr v2.4.2 (<a
href="https://redirect.github.com/ossf/scorecard-action/issues/1548">#1548</a>)</li>
<li><a
href="https://github.com/ossf/scorecard-action/commit/b225da6b2b97811a123bb34532642f3ad6a4f011"><code>b225da6</code></a>
Bump github.com/ossf/scorecard/v5 from v5.2.0 to v5.2.1 (<a
href="https://redirect.github.com/ossf/scorecard-action/issues/1550">#1550</a>)</li>
<li><a
href="https://github.com/ossf/scorecard-action/commit/9399f6f42496e38fbb8dbcf85e17223226a5dafe"><code>9399f6f</code></a>
:seedling: Bump the docker-images group across 1 directory with 2
updates (<a
href="https://redirect.github.com/ossf/scorecard-action/issues/1">#1</a>...</li>
<li><a
href="https://github.com/ossf/scorecard-action/commit/e1daa8c5c7ed469dbb0167e261ed1c9fa673a9ae"><code>e1daa8c</code></a>
:seedling: Bump the github-actions group across 1 directory with 5
updates (#...</li>
<li><a
href="https://github.com/ossf/scorecard-action/commit/9fe6511b9b36af3b03200e49cf8fb09d261b5402"><code>9fe6511</code></a>
:seedling: Bump golang.org/x/net from 0.39.0 to 0.40.0 (<a
href="https://redirect.github.com/ossf/scorecard-action/issues/1542">#1542</a>)</li>
<li><a
href="https://github.com/ossf/scorecard-action/commit/25b9cd9cd11610dcac11e59afed9910714b12129"><code>25b9cd9</code></a>
:seedling: Bump github.com/ossf/scorecard/v5 from v5.1.1 to v5.2.0 (<a
href="https://redirect.github.com/ossf/scorecard-action/issues/1547">#1547</a>)</li>
<li><a
href="https://github.com/ossf/scorecard-action/commit/18cc9b81307fc5ab3c2cd7092955f06dcfdf8c42"><code>18cc9b8</code></a>
:seedling: Bump golang.org/x/net from 0.38.0 to 0.39.0 (<a
href="https://redirect.github.com/ossf/scorecard-action/issues/1536">#1536</a>)</li>
<li><a
href="https://github.com/ossf/scorecard-action/commit/db7814227b097a902957aa24d989c6e473613a8e"><code>db78142</code></a>
:seedling: Bump the github-actions group with 2 updates (<a
href="https://redirect.github.com/ossf/scorecard-action/issues/1538">#1538</a>)</li>
<li><a
href="https://github.com/ossf/scorecard-action/commit/de386ed459e2f85111697f50fe076d0ea617a32f"><code>de386ed</code></a>
:seedling: Bump golang from 1.24.1 to 1.24.2 in the docker-images group
(<a
href="https://redirect.github.com/ossf/scorecard-action/issues/1534">#1534</a>)</li>
<li><a
href="https://github.com/ossf/scorecard-action/commit/5b7cedba4eccfb66a6277e40cbe18d1d559ecc00"><code>5b7cedb</code></a>
:seedling: Bump github.com/sigstore/cosign/v2 from 2.4.3 to 2.5.0 (<a
href="https://redirect.github.com/ossf/scorecard-action/issues/1537">#1537</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/ossf/scorecard-action/compare/f49aabe0b5af0936a0987cfb85d86b75731b0186...05b42c624433fc40578a4040d5cf5e36ddca8cde">compare
view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=ossf/scorecard-action&package-manager=github_actions&previous-version=2.4.1&new-version=2.4.2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)

</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
…nnx#51)

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
1. It's now possible to do `node.attributes.add(ir.Attr(...))` to avoid
having to get the name as a redundant step.
2. Also allow node attributes to be initialized with a dictionary
    - This way users do not have to use
    ```py
    ir.Node(attributes=node.attributes.values())
    ```
	when copying the node. Instead, it is possible to

    ```py
    ir.Node(attributes=node.attributes)
    ```
3. Implement get_* methods on attributes to make getting default
attributes easier.

    Before
    ```py
    attr = node.attributes.get("attr")
    if attr is not None:
        value = attr.as_int()
    else:
        value = 42
    ```

    now

    ```py
    value = node.attributes.get_int("attr", 42)
    ```

---------

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
Ignore unit tests in coverage reports

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
Signed-off-by: Ti-Tai Wang <titaiwang@microsoft.com>
@justinchuby
Copy link
Member

Will merge and allow further changes as follow ups to make sure new changes are clear and easy to review, thanks!

@justinchuby justinchuby enabled auto-merge (squash) June 2, 2025 23:22
@justinchuby justinchuby merged commit 60f8692 into onnx:main Jun 2, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants