publish binary executable and update gitignore #36
+75
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you a lot @cuichenli . Let me put this PR on hold temporarily, as we require that our binaries are signed. |
|
@cuichenli thank you for the contribution. The requirement that @mariomac points out, that our binaries need to be signed and verifiable, is a foundational feature we need to provide to resolve this issue. We are looking into resources to provide this trust-chain, but until then we are not able to accept this PR. I'm going to close this as it does not meet our requirements. We will update #13 with more information about signing when it becomes available and would value your contribution if you would like to resolve that issue at that point. Thanks again 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #13
basically copied the content from https://github.com/grafana/beyla/blob/main/.github/workflows/release-binaries-base.yml and updated file name accordingly and changed the runner. have tested in my own repository: https://github.com/cuichenli/opentelemetry-ebpf-instrumentation/releases/tag/v0.0.2
also added a new gitignore file in the java code directory, as it automatically built once open in vscode.