Tomcat metrics definitions updated in JMX Scraper #1754
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsunday
commented
Feb 20, 2025
| @@ -14,7 +14,7 @@ rules: | |||
| mapping: | |||
| activeSessions: | |||
| metric: tomcat.sessions | |||
| type: gauge | |||
| type: updowncounter | |||
There was a problem hiding this comment.
Seems to be a better fit here. UpDownCounter is also used here in tomcat.yaml from opentelemetry-java-instrumentation project
robsunday
commented
Feb 20, 2025
| type: counter | ||
| unit: "{request}" | ||
| desc: The total requests | ||
| maxTime: | ||
| metric: max_time | ||
| metric: request.duration.max |
There was a problem hiding this comment.
request.duration is is taken from HTTP semconv
robsunday
commented
Feb 20, 2025
| type: counter | ||
| unit: By | ||
| desc: The number of bytes transmitted and received | ||
| metric: &metric network.io |
There was a problem hiding this comment.
Yaml anchors and references used to improve maintainability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1748
This is the first part of Tomcat metrics definition to make them aligned with semconv. If these changes are accepted then tha same changes will be done in JMX Metrics Gatherer component.
OTel reference documentation I used: