add test for Mac OS and Windows #1934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trask can you help with the windows error? |
I think you need to add double quotes below
|
laurit
reviewed
Jun 4, 2025
| import org.junit.jupiter.api.io.TempDir; | ||
|
|
||
| @EnabledOnOs(LINUX) // Uses async-profiler, which is only supported on Linux |
There was a problem hiding this comment.
async profiler works on mac, see https://github.com/async-profiler/async-profiler
trask
reviewed
Jun 5, 2025
trask
reviewed
Jun 5, 2025
trask
reviewed
Jun 5, 2025
trask
reviewed
Jun 5, 2025
trask
reviewed
Jun 18, 2025
trask
reviewed
Jun 18, 2025
|
@trask please check again |
|
🔧 The result from spotlessApply was committed to the PR branch. |
|
@zeitlinger sorry for the delay, I finally realized the difference between this and the link checking is that this is using the GitHub Rest API, which is more heavily throttled for anonymous users, so instead I changed it to avoid the Rest API |
trask
approved these changes
Jun 28, 2025
Merged
via the queue into
open-telemetry:main
with commit Jun 29, 2025
3c1269e
29 of 30 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates #1907
Using the same config as https://github.com/open-telemetry/opentelemetry-java/blob/main/.github/workflows/build.yml