You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
// opts
-Dotel.instrumentation.jdbc.experimental.capture-query-parameters=true
// and somewhere in the code
JdbcTelemetry.create(otel).wrap(ds)
I think people will expect the opt to be enabled and get data in my spans. But as per the current implementation, JdbcTelemetryBuilder only relies on properties set explicitly such as builder.setCaptureQueryParameters(true).
I see that in OpenTelemetryDataSource there is a deprecated constructor relying on JdbcInstrumenterFactory which allows construction based on the opts. It has been deprecated with introduction of JdbcTelemetry andJdbcTelemetryBuilder.
Describe the solution you'd like
Would it be possible to provide something like JdbcTelemetry.autoConfigured(otel) for this use case or is it something that has been not allowed on purpose?
Describe alternatives you've considered
No response
Additional context
I'd be happy to implement it as soon as we have a solution!
The text was updated successfully, but these errors were encountered:
Would it be possible to provide something like JdbcTelemetry.autoConfigured(otel) for this use case or is it something that has been not allowed on purpose?
If something like this were to be implemented it would need to be consistently implemented for all of the library instrumentations. It is unlikely that just using system properties and environment variables is going to cut it as someone is bound to ask for providing configuration through spring properties etc.
Uh oh!
There was an error while loading. Please reload this page.
Is your feature request related to a problem? Please describe.
I think people will expect the opt to be enabled and get data in my spans. But as per the current implementation,
JdbcTelemetryBuilder
only relies on properties set explicitly such asbuilder.setCaptureQueryParameters(true)
.I see that in
OpenTelemetryDataSource
there is a deprecated constructor relying onJdbcInstrumenterFactory
which allows construction based on the opts. It has been deprecated with introduction ofJdbcTelemetry
andJdbcTelemetryBuilder
.Describe the solution you'd like
Would it be possible to provide something like
JdbcTelemetry.autoConfigured(otel)
for this use case or is it something that has been not allowed on purpose?Describe alternatives you've considered
No response
Additional context
I'd be happy to implement it as soon as we have a solution!
The text was updated successfully, but these errors were encountered: