Skip to content

Make the OTel starter work with GraalVM native 22 and 23 #13500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2025

Conversation

jeanbisutti
Copy link
Member

@jeanbisutti jeanbisutti commented Mar 12, 2025

GraalVM native is supported by Spring Boot for version 22 or above: https://docs.spring.io/spring-boot/system-requirements.html#getting-started.system-requirements.graal

So, this PR executes the GraalVM native tests for 22 and 23.

@jeanbisutti jeanbisutti requested a review from a team as a code owner March 12, 2025 10:08
@jeanbisutti jeanbisutti marked this pull request as draft March 12, 2025 10:08
@github-actions github-actions bot added the test native This label can be applied to PRs to trigger them to run native tests label Mar 12, 2025
@jeanbisutti jeanbisutti changed the title Make the OTel starter works with GraalVM native 22 and 23 Make the OTel starter work with GraalVM native 22 and 23 Mar 12, 2025
@jeanbisutti jeanbisutti added this to the v2.14.0 milestone Mar 12, 2025
@jeanbisutti jeanbisutti reopened this Mar 12, 2025
@jeanbisutti
Copy link
Member Author

--initialize-at-build-time=io.opentelemetry.instrumentation.logback.appender.v1_0.internal.LoggingEventMapper was introduced in the first GraalVM native tests to make the OTel Logback appender work on native mode.

It has led to the addition of other build time initializations when additional features were added to this repo. The strict-image-heap mode enabled by default from GraalVM 22 makes the things worse.

However, the LoggingEventMapper build time initialization is no longer needed and other build time initializations can be removed.

@jeanbisutti jeanbisutti marked this pull request as ready for review March 12, 2025 13:12
@trask trask merged commit f623564 into open-telemetry:main Mar 12, 2025
86 checks passed
@zeitlinger zeitlinger mentioned this pull request Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test native This label can be applied to PRs to trigger them to run native tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants