Support http semconv 1.32.0 #13697
Open
Support http semconv 1.32.0 #13697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstrumentation/api/incubator/semconv/messaging/MessagingMetricsAdvice.java Co-authored-by: Lauri Tulmin <tulmin@gmail.com>
…nstrumentation/api/incubator/semconv/messaging/MessagingProducerMetrics.java Co-authored-by: Lauri Tulmin <tulmin@gmail.com>
…nstrumentation/api/incubator/semconv/messaging/MessagingProducerMetricsTest.java Co-authored-by: Steve Rao <raozihao.rzh@alibaba-inc.com>
…nstrumentation/api/incubator/semconv/messaging/MessagingProducerMetricsTest.java Co-authored-by: Steve Rao <raozihao.rzh@alibaba-inc.com>
trask
reviewed
Apr 11, 2025
trask
reviewed
Apr 14, 2025
| ServerAttributes.SERVER_ADDRESS, | ||
| ServerAttributes.SERVER_PORT)); | ||
| ServerAttributes.SERVER_PORT, | ||
| UrlAttributes.URL_SCHEME)); |
There was a problem hiding this comment.
this is opt-in, so users would need to provide their own metric view to override this
Comment on lines
+54
to
+55
| ServerAttributes.SERVER_ADDRESS, | ||
| ServerAttributes.SERVER_PORT)); |
| HttpAttributes.HTTP_REQUEST_METHOD, UrlAttributes.URL_SCHEME)); | ||
| // https://github.com/open-telemetry/semantic-conventions/blob/v1.32.0/docs/http/http-metrics.md#metric-httpserveractive_requests | ||
| HttpAttributes.HTTP_REQUEST_METHOD, UrlAttributes.URL_SCHEME, | ||
| ServerAttributes.SERVER_ADDRESS, ServerAttributes.SERVER_PORT)); |
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
server.address,server.portto thehttp.server.request.durationmetric.server.address,server.portto thehttp.server.active_requestsmetric.server.address,server.portto thehttp.server.request.body.sizemetric.url.schemeto thehttp.client.request.durationmetric.url.schemeto thehttp.client.request.body.sizemetric.url.schemeto thehttp.client.response.body.sizemetric.