-
Notifications
You must be signed in to change notification settings - Fork 979
semconv stable code #13860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
semconv stable code #13860
Conversation
🔧 The result from spotlessApply was committed to the PR branch. |
…nstrumentation into semconv-stable-code
…nstrumentation into semconv-stable-code
🔧 The result from spotlessApply was committed to the PR branch. |
I have updated this PR to only emit the deprecated semantic convention attributes by default. Using Then, we could then later remove the support for the unstable Is there already an issue that contains a list of breaking changes that we are planning to include in this major release to track progress on their respective implementations ? If no, please let me know and I can create one so we don't forget about this (and also the database semconv). |
https://github.com/open-telemetry/opentelemetry-java-instrumentation/milestone/41 |
Thanks, I've opened #14059. @trask your review status is still "requested change", do you think there are still things to change before we could merge this ? |
…nstrumentation into semconv-stable-code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
instrumentation/grails-3.0/javaagent/src/test/java/test/GrailsTest.java
Outdated
Show resolved
Hide resolved
...esting/src/main/java/io/opentelemetry/instrumentation/jaxrs/AbstractJaxRsHttpServerTest.java
Outdated
Show resolved
Hide resolved
...esting/src/main/java/io/opentelemetry/instrumentation/jaxrs/AbstractJaxRsHttpServerTest.java
Outdated
Show resolved
Hide resolved
...esting/src/main/java/io/opentelemetry/instrumentation/jaxrs/AbstractJaxRsHttpServerTest.java
Outdated
Show resolved
Hide resolved
instrumentation/logback/logback-appender-1.0/library/build.gradle.kts
Outdated
Show resolved
Hide resolved
instrumentation/rxjava/rxjava-2.0/javaagent/src/test/java/BaseRxJava2WithSpanTest.java
Outdated
Show resolved
Hide resolved
...in/java/io/opentelemetry/instrumentation/spring/webmvc/boot/AbstractSpringBootBasedTest.java
Show resolved
Hide resolved
...in/java/io/opentelemetry/instrumentation/spring/webmvc/filter/AbstractServletFilterTest.java
Outdated
Show resolved
Hide resolved
…nstrumentation into semconv-stable-code
🎉 |
Semconv 1.33.0 brings stable definitions for
code.*
namespace, which includes the following changes:code.namespace
is removedcode.function
is renamed tocode.function.name
and needs to include fully-qualified name of the class in addition to the functioncode.lineno
has been renamedcode.line.number
code.column
has been renamedcode.column.number
code.filepath
has been renamedcode.file.path
This PR might have to be updated if merged after the update to semconv 1.33.0 is merged first.EDIT: updated after 1.34.0 semconv updateEDIT: the existing
code.*
semantic conventions are still produced, the stable ones are opt-in by setting theotel.semconv-stability.opt-in
config option to includecode
(only stable) orcode/dup
(both stable + old).