Skip to content

semconv stable code #13860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 101 commits into from
Jun 25, 2025
Merged

semconv stable code #13860

merged 101 commits into from
Jun 25, 2025

Conversation

SylvainJuge
Copy link
Contributor

@SylvainJuge SylvainJuge commented May 15, 2025

Semconv 1.33.0 brings stable definitions for code.* namespace, which includes the following changes:

  • code.namespace is removed
  • code.function is renamed to code.function.name and needs to include fully-qualified name of the class in addition to the function
  • code.lineno has been renamed code.line.number
  • code.column has been renamed code.column.number
  • code.filepath has been renamed code.file.path

This PR might have to be updated if merged after the update to semconv 1.33.0 is merged first. EDIT: updated after 1.34.0 semconv update

EDIT: the existing code.* semantic conventions are still produced, the stable ones are opt-in by setting the otel.semconv-stability.opt-in config option to include code (only stable) or code/dup (both stable + old).

@SylvainJuge SylvainJuge self-assigned this May 15, 2025
@github-actions github-actions bot added the test native This label can be applied to PRs to trigger them to run native tests label May 15, 2025
@otelbot-java-instrumentation
Copy link
Contributor

🔧 The result from spotlessApply was committed to the PR branch.

@otelbot-java-instrumentation
Copy link
Contributor

🔧 The result from spotlessApply was committed to the PR branch.

@SylvainJuge
Copy link
Contributor Author

I have updated this PR to only emit the deprecated semantic convention attributes by default.
Most instrumentation remain tested with unstable attributes, but some (like log appenders) are tested with both.

Using otel.semconv-stability.opt-in configuration allows to opt-in for the new stable semantic conventions with code or code/dup like we have for the database attributes, so it means we could merge this PR without altering the current behavior.

Then, we could then later remove the support for the unstable code attributes when preparing for the 3.0 release.

Is there already an issue that contains a list of breaking changes that we are planning to include in this major release to track progress on their respective implementations ? If no, please let me know and I can create one so we don't forget about this (and also the database semconv).

@trask
Copy link
Member

trask commented Jun 18, 2025

Is there already an issue that contains a list of breaking changes that we are planning to include in this major release to track progress on their respective implementations ?

https://github.com/open-telemetry/opentelemetry-java-instrumentation/milestone/41

@SylvainJuge
Copy link
Contributor Author

Is there already an issue that contains a list of breaking changes that we are planning to include in this major release to track progress on their respective implementations ?

https://github.com/open-telemetry/opentelemetry-java-instrumentation/milestone/41

Thanks, I've opened #14059.

@trask your review status is still "requested change", do you think there are still things to change before we could merge this ?

@trask trask dismissed their stale review June 18, 2025 16:22

stale

Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@trask trask merged commit d8723a4 into open-telemetry:main Jun 25, 2025
90 of 91 checks passed
@trask
Copy link
Member

trask commented Jun 25, 2025

🎉

@SylvainJuge SylvainJuge deleted the semconv-stable-code branch June 25, 2025 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test native This label can be applied to PRs to trigger them to run native tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants