Skip to content

Filter metrics by scope #14136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2025
Merged

Conversation

jaydeluca
Copy link
Member

@jaydeluca jaydeluca commented Jun 25, 2025

Related to #14098 and #13468

We implemented a scope filter for span data to avoid including telemetry emitted by other instrumentations during tests, this change brings that same approach to metrics. When we process the instrumentation module, we only include the metrics that match the instrumentation scope.

After applying this change, it caught and reverted two modules that were incorrectly reporting metrics that were actually from the io.opentelemetry.netty-4.1 scope.

The new metrics file format groups the metrics under metrics_by_scope, for example:

when: default
metrics_by_scope:
  - scope: io.opentelemetry.oracle-ucp-11.2
    metrics:
      - name: db.client.connections.usage
        description: The number of connections that are currently in state described by the state attribute.
        type: LONG_SUM
        unit: connections
        attributes: 
          - name: pool.name
            type: STRING
          - name: state
            type: STRING

@jaydeluca jaydeluca requested a review from a team as a code owner June 25, 2025 21:47
telemetry:
- when: default
metrics:
- name: http.client.request.duration
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the two metrics removed in this PR were both from io.opentelemetry.netty-4.1 instead of these other instrumentations

@trask trask merged commit 7689228 into open-telemetry:main Jun 28, 2025
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants