how to map declarative config properties #14144
Conversation
|
@trask @jack-berg please have a look |
| db-statement-sanitizer: | ||
| enabled: true # already exists - just for reference | ||
| thread_details: | ||
| enabled: true # was "otel.javaagent.add-thread-details" = "true" |
There was a problem hiding this comment.
alternatively: spans: enabled: true
There was a problem hiding this comment.
it's a good question
honestly I wonder how useful this instrumentation is, and whether we should disable it by default in 3.0 @laurit?
I guess my preference would be
- disabled by default
- enabled applies to both spans and logs (but not metrics due to high cardinality)
There was a problem hiding this comment.
I guess we could apply this new semantic also to the spring starter where this feature is added without declarative config in #14117
| - Content-Type | ||
| - Content-Encoding | ||
| java: | ||
| agent: |
There was a problem hiding this comment.
agent just looks better that javaagent here
|
@jack-berg I think we could get this unblocked with your feedback 😄 |
|
Strictly speaking we don't need to merge this, as we normally don't have spec PRs in this repo. Eventually, this doc should end up in the docs repo. |
- use sdk style discriminator for logging - use common "enabled" for "default-enabled"
This is a specification PR - implementation issues will be created when this PR is merged.
Fixes #14132