-
Notifications
You must be signed in to change notification settings - Fork 526
fix: MetricExporters use getter methods instead of direct access #2973
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: MetricExporters use getter methods instead of direct access #2973
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2973 +/- ##
=======================================
- Coverage 81.3% 81.2% -0.1%
=======================================
Files 126 126
Lines 24375 24394 +19
=======================================
+ Hits 19827 19828 +1
- Misses 4548 4566 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -65,6 +65,12 @@ also modified to suppress telemetry before invoking exporters. | |||
- `HistogramDataPoint` no longer exposes `bounds` and `bucket_counts`, but | |||
instead offers `bounds()` and `bucket_counts()` methods that returns an | |||
iterator over the same. | |||
- `Metric` no longer exposes `name`, `description`, `unit`, `data` fields, but |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The individual instrument and their datapoint related structs (such as Sum
, SumDataPoint
, etc.) also have some public fields where we can use getters.
It could be nice to have include rationale in PRs. |
Fixes #
Design discussion issue (if applicable) #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes