Skip to content

chore: remove unused glob #3035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

Conversation

yoshi-taka
Copy link
Contributor

glob crate was introduced in #1301,
but became unused in #2988.

Changes

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@yoshi-taka yoshi-taka requested a review from a team as a code owner June 21, 2025 04:30
@yoshi-taka yoshi-taka changed the title chore: remove glob chore: remove unused glob Jun 21, 2025
Copy link

codecov bot commented Jun 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.1%. Comparing base (0c2f808) to head (3c2266c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3035   +/-   ##
=====================================
  Coverage   81.1%   81.1%           
=====================================
  Files        126     126           
  Lines      24954   24954           
=====================================
  Hits       20255   20255           
  Misses      4699    4699           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Not sure why cargo-machete didn't catch this.

@yoshi-taka
Copy link
Contributor Author

The documentation for cargo shear includes a comparison with similar tools, if you’re interested.
https://crates.io/crates/cargo-shear

@lalitb
Copy link
Member

lalitb commented Jun 23, 2025

Thanks for sharing. Cargo shear seems more thorough and precise, we can revisit it if more such cases get undetected.

@lalitb lalitb merged commit af2f144 into open-telemetry:main Jun 23, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants