This repository was archived by the owner on Feb 19, 2023. It is now read-only.
Added test for PDF011 #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #17 +/- ##
==========================================
+ Coverage 84.70% 85.58% +0.88%
==========================================
Files 26 26
Lines 340 340
==========================================
+ Hits 288 291 +3
+ Misses 52 49 -3
Continue to review full report at Codecov.
|
MarcoGorelli
suggested changes
Apr 10, 2021
tests/namespace_usage_test.py
Outdated
Comment on lines
38
to
48
| ( | ||
| pytest.param( | ||
| "from pandas import Categorical\n" | ||
| "import pandas as pd\n" | ||
| "\n" | ||
| "cat1 = Categorical()\n" | ||
| "cat2 = pd.Categorical()\n", | ||
| "5:7: PDF011 found both 'pd.foo' and 'foo' in the same file", | ||
| id="One is accessed from pd, the other is imported from pandas", | ||
| ), | ||
| ), |
There was a problem hiding this comment.
Awesome!
Can we add an extra test in which we have
import pandas
from pandas import Categorical
cat1 = Categorical()
cat2 = pandas.Categorical()
?
There was a problem hiding this comment.
if it doesn't pass, that's OK, let me know and I'll open a new issue for it and we can merge this one as it is
There was a problem hiding this comment.
Thanks! Just added it.
MarcoGorelli
approved these changes
Apr 10, 2021
|
Thank you @MarcoGorelli!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing issue #13.