Skip to content

Fix/p5sound #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2025
Merged

Fix/p5sound #792

merged 3 commits into from
Apr 11, 2025

Conversation

davepagurek
Copy link
Collaborator

Resolves #790

Also reverts #781 which tried to fix another issue but created this one.

  • We usually load p5 through script injection for caching purposes
  • This messes up the load order with p5.sound, so we load p5 the usual way with slightly less efficient caching policies in that case.
  • Previously to Remove CDN script tag from embedded sketches #781, there was a bug where it was also loading p5 the usual way ALL THE TIME.
  • After Remove CDN script tag from embedded sketches #781, p5.sound examples broke because it NEVER loads p5 the usual way.
  • This fixes the actual issue, where not passing scripts (as opposed to passing []) would cause the cdn link to get added mistakenly.

…le-render"

This reverts commit ed6b299, reversing
changes made to d875f93.
@davepagurek davepagurek merged commit 70890af into main Apr 11, 2025
4 checks passed
@davepagurek davepagurek deleted the fix/p5sound branch April 11, 2025 12:44
davepagurek added a commit that referenced this pull request Apr 11, 2025
Fix/p5sound
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Managing multiple p5 and add-on imports in reference pages
1 participant