-
Notifications
You must be signed in to change notification settings - Fork 150
Back button/history broken in Firefox on reference pages #822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Update: actually I think this is broken in Chrome as well... |
confirmed in Linux Mint with FF 138.0.1 |
The scrolling threshold, below which the back-button is broken, seems to be the moment the content loaded in the This is the console log when pressing the back-button.
Maybe related to withastro/astro#11919 ? |
Thanks for the investigation, both! @antiboredom if you have time after 15th and if no one else volunteers, please ping here, happy to assign. |
I did a git bisect as I know this wasn't the behavior before, I tracked it down to be introduced by #812. I need to look up what preact is doing in this case but it seems to be pushing history entry whenever a sketch is unloaded on the page. |
Ok I think I found the root cause although it is not definitive. Every navigation within an iframe will be counted as a history entry in the top most document, typically changing the However we are not using the @davepagurek Seeing as you did the original implementation, can you have a look at the above to see if it made sense to you. I'll make a PR to fix as such. |
Most appropriate sections of the p5.js website?
Reference
What is your operating system?
Mac OS
Web browser and version
Firefox 137.0.2
Actual Behavior
The back button doesn't work in Firefox when browsing reference pages. Something about individual reference pages is filling the browser history. Note: it seems to work fine in chrome!
Expected Behavior
Going back a page from a a function reference should take you back to the main reference page.
Steps to reproduce
To reproduce, open the reference page, click on
arc()
(or any other function), scroll down, then try to go back a page (or just take a look at the history). This only happens if you scroll down a bit, so perhaps it has something to do with the embedded sketches?Would you like to work on the issue?
Unfortunately I don't have time at the moment, but would be happy to take a look after may 15th if no one else is able to get to it before then.
The text was updated successfully, but these errors were encountered: