Skip to content

added docs for code in p5.Color #7906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 244 commits into from

Conversation

FerrinThreatt
Copy link

addresses #6971

Changes:
added documentation to _getBrightness() and _getGreen() functions

PR Checklist

min-kim42 and others added 30 commits November 2, 2024 08:53
…dd-thrly

docs: add thrly as a contributor for doc, and code
…dd-lirenjie95

docs: add lirenjie95 as a contributor for doc, and code
…dd-philyawj

docs: add philyawj as a contributor for doc
…dd-akkarn1689

docs: add akkarn1689 as a contributor for code
…dd-xinemata

docs: add xinemata as a contributor for eventOrganizing, tutorial, and 3 more
…dd-Vaivaswat2244

docs: add Vaivaswat2244 as a contributor for code
…dd-dkessner

docs: add dkessner as a contributor for example
…dd-AnimeshSinha1309

docs: add AnimeshSinha1309 as a contributor for example
allcontributors bot and others added 28 commits May 18, 2025 18:50
…dd-yugalkaushik

docs: add yugalkaushik as a contributor for code, and doc
Reduce contributor avatar image size to 64px for improved performance processing#7788
…op-ignoring-colorMode

fix: push() ignoring the ColorMode processing#7402
…sh-and-pop-ignoring-colorMode

Revert "fix: push() ignoring the ColorMode processing#7402"
…dd-irina-wang

docs: add irina-wang as a contributor for example
…dd-jennybkowalski

docs: add jennybkowalski as a contributor for ideas
…dd-Wlaith

docs: add Wlaith as a contributor for ideas
…dd-jep-a

docs: add jep-a as a contributor for ideas
docs: add dpanshug as a contributor for doc
…_yarn/elliptic-6.6.1

Bump elliptic from 6.6.0 to 6.6.1
@ksen0
Copy link
Member

ksen0 commented Jun 12, 2025

Hi @FerrinThreatt ! This looks like it's still based on the main branch rather than on dev-2.0. Although it could be possible in another situation to use git cherry-pick to add the documentation you're proposing in the commit, in this case the p5.Color.js file has changed too much.

Could you please manually make your changes using the dev-2.0 branch:

git fetch
git checkout dev-2.0
git checkout -b your_branch_name

Then manually apply your changes where needed, and create an new PR. Sorry that it's a challenging part of the codebase to get start with, because of the updates between the versions!

Is your intent to have several different PRs, one for this documentation and one for the contrast checker?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.