Ported the stroke shader to WebGPU renderer #7915
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davepagurek
reviewed
Jun 16, 2025
src/webgpu/p5.RendererWebGPU.js
Outdated
| @@ -665,7 +675,7 @@ class RendererWebGPU extends Renderer3D { | |||
| new RegExp(`struct\\s+${structName}\\s*\\{([^\\}]+)\\}`) | |||
| ); | |||
| if (!structMatch) { | |||
| throw new Error(`Can't find a struct definition for ${structName}`); | |||
| throw new Error(`Can't find a struct defnition for ${structName}`); | |||
There was a problem hiding this comment.
Looks like a character got lost in here?
There was a problem hiding this comment.
Hmm true sorry, growing pains from switching text editor
src/webgpu/shaders/line.js
Outdated
| discard; | ||
| } | ||
| } | ||
| var col = HOOK_getFinalColor(vec4<f32>(inputs.color.rgb, 1.) * inputs.color.a); |
There was a problem hiding this comment.
oh I noticed this and updated it in the color shader too, but I had intended the hooks to always get un-multiplied alpha, so the multiplication by the alpha channel would happen after the hook instead of before. The GLSL version of this may need that update too
davepagurek
reviewed
Jun 16, 2025
| console.log( | ||
| "🌸 p5.js says: Instancing is only supported in WebGL2 mode" | ||
| ); | ||
| } |
There was a problem hiding this comment.
Might be missing a } here
davepagurek
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
I've ported the WebGL/ GLSL stroke shader to the experimental WebGPU renderer. It also includes the hooks.
Screenshots of the change:
