use javaproperties library to parse #77
Merged
+4
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for processing-contributions ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
apologies, I'm on the east coast, so this will come to you rather late in your day. Of course, please ignore till you have time. This is mainly to notify you of the work. I will likely merge later today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #76 by using a library specifically designed to treat java property files in python.
This means all escaped characters will be dealt with properly.
This was tested with the VJ Motion library, which does have an escaped colon in the value of url.
the output for the script is below, showing no escaped colons in the values.
properties dict: {'type': 'library', 'source': 'https://github.com/vincentsijben/vjmotion-processing/releases/latest/download/VJMotion.txt', 'name': 'VJ Motion', 'authors': 'Vincent Sijben', 'url': 'https://vincentsijben.github.io/vjmotion-processing/', 'categories': 'Sound,Utilities,Math', 'sentence': 'A collection of helper functions to create live, audio-reactive visuals with BPM-synced animation, Arduino input and frequency analyzing.', 'paragraph': '', 'version': 8, 'prettyVersion': '0.0.8', 'minRevision': 0, 'maxRevision': 0}
T