-
-
Notifications
You must be signed in to change notification settings - Fork 132
Updating support for Array API to v2024.12 #863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There are a total of 96 new failures. I'll keep trying to fix the easy ones in the following commits. |
CodSpeed Performance ReportMerging #863 will degrade performances by 24.09%Comparing Summary
Benchmarks breakdown
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small edit.
@hameerabbasi Could you trigger the CI run? |
I'd suggest pushing an empty commit -- seems like the CI checks failed to start for some other reason. We only restrict them for someone making their first PR. |
We also need to bump the commit hash of |
How to get the commit hash? |
Look at the current hash at the default branch of the array api tests repo. And then adjust the list of failures accordingly; it'll change. |
The tests pass for me locally, but they fail for ci. |
Try pinning the hypothesis version in CI to what you have locally. |
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
for more information, see https://pre-commit.ci
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
for more information, see https://pre-commit.ci
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
for more information, see https://pre-commit.ci
9bf22d0
to
7b9f7d8
Compare
@prady0t Do you mind if we merge this and iterate on it? |
Slept while waiting for Finch tests to pass 🙂 . Yes, let's merge this. |
Fixes #858