Skip to content

feat: add support for aux addresses in docker.network() operation #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DonDebonair
Copy link
Contributor

When setting up a Docker Network using the macvlan driver, it's common to reserve "aux addresses", for example for reserving an address to loop back to the host.

This PR let's you specify that.

  • Pull request is based on the default branch (3.x at this time)
  • Pull request includes tests for any new/updated operations/facts
  • Pull request includes documentation for any new/updated operations/facts
  • Tests pass (see scripts/dev-test.sh)
  • Type checking & code style passes (see scripts/dev-lint.sh)

@DonDebonair
Copy link
Contributor Author

The changes in this PR have nothing to do with the code for which tests are failing. I had the same problem when running tests locally. The SSHConnection tests are somehow failing.

@Fizzadar
Copy link
Member

The changes in this PR have nothing to do with the code for which tests are failing. I had the same problem when running tests locally. The SSHConnection tests are somehow failing.

Augh these fails are driving me mad, cannot repro locally. If you can repro them locally mind me asking what your setup is? Would be good to squash these - seem very intermittent on GH and constantly breaking peoples PRs!

Copy link
Member

@Fizzadar Fizzadar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice add, thanks for the PR @DonDebonair!

@Fizzadar Fizzadar merged commit b1dcf16 into pyinfra-dev:3.x Jun 23, 2025
75 of 92 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants