Skip to content

Commit a8cba5c

Browse files
committed
Fix corner case when no result attibute is found in gtest output
1 parent 0b05b80 commit a8cba5c

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# 2.1.1 (2021-12-06)
2+
3+
- Fix corner-case issue when no result attribute is found in google test XML output file.
4+
15
# 2.1.0 (2021-12-03)
26

37
- Added support for `GTEST_SKIP()` skipped message from Google Test `1.11`.

src/pytest_cpp/google.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ def _parse_xml(self, xml_filename):
122122
for failure_elem in failure_elements:
123123
failures.append(failure_elem.text)
124124
skippeds = []
125-
if test_case.attrib["result"] == "skipped":
125+
if test_case.attrib.get("result", None) == "skipped":
126126
# In gtest 1.11 a skipped message was added to
127127
# the output file
128128
skipped_elements = test_case.findall("skipped")
@@ -133,7 +133,7 @@ def _parse_xml(self, xml_filename):
133133
# append a "skipped" keyword
134134
if not skipped_elements:
135135
skippeds.append("Skipped")
136-
if test_case.attrib["status"] == "notrun":
136+
elif test_case.attrib.get("status", None) == "notrun":
137137
skippeds.append("Disabled")
138138
result.append((test_suite_name + "." + test_name, failures, skippeds))
139139

0 commit comments

Comments
 (0)