Adding pydot --fixture-graph

[fruch]

This change is 

[coveralls]

Changes Unknown when pulling 2185cd5 on fruch:master into ** on pytest-dev:master**.

[coveralls]

Changes Unknown when pulling 2185cd5 on fruch:master into ** on pytest-dev:master**.

[coveralls]

Changes Unknown when pulling 81f96a5 on fruch:master into ** on pytest-dev:master**.

[fruch]

@bubenkoff @amakhnach I've did some changes to CI, and also remove the usage of tox (i.e. not much need in Travis anymore)

I think this one is very helpful (it was to me), would be honored to have it in.

[bubenkoff]

Review status: 0 of 6 files reviewed at latest revision, 2 unresolved discussions.

---

pytest_fixture_tools/plugin.py, line 141 at r2 (raw file):

LOG_DEST_DIR
This is both undocumented and not so flexible - I would then make it a command line argument so --fixture-graph=

---

pytest_fixture_tools/plugin.py, line 147 at r2 (raw file):

        tw.line()
        tw.sep("-", "fixture-graph")
        tw.line("created at {}.dot.".format(filename))

how about to directly generate a png file, so people will not have to run dot manually?
also need to document the optional dependency of course

---

Comments from Reviewable

[coveralls]

Changes Unknown when pulling 644f17a on fruch:master into ** on pytest-dev:master**.

[fruch]

Review status: 0 of 7 files reviewed at latest revision, 2 unresolved discussions, some commit checks failed.

---

pytest_fixture_tools/plugin.py, line 141 at r2 (raw file):

Previously, bubenkoff (Anatoly Bubenkov) wrote…

LOG_DEST_DIR
This is both undocumented and not so flexible - I would then make it a command line argument so --fixture-graph=

I've removed this one, and added a new command line param for the output-dir

---

pytest_fixture_tools/plugin.py, line 147 at r2 (raw file):

Previously, bubenkoff (Anatoly Bubenkov) wrote…

how about to directly generate a png file, so people will not have to run dot manually?
also need to document the optional dependency of course

I've updated it, hopfully it's clearer now

---

Comments from Reviewable

[coveralls]

Changes Unknown when pulling a232b7c on fruch:master into ** on pytest-dev:master**.

[bubenkoff]

Review status: 0 of 7 files reviewed at latest revision, 2 unresolved discussions.

---

pytest_fixture_tools/plugin.py, line 39 at r3 (raw file):

                    action="store_true", dest="fixture_graph", default=False,
                    help="create .dot fixture graph for each test")
    group.addoption('--fixture-graph-output-dir',

please document in the readme

---

pytest_fixture_tools/plugin.py, line 42 at r3 (raw file):

                    action="store_true", dest="fixture_graph_output_dir", default="artifacts",
                    help="select the location for the output of fixture graph. defaults to 'artifacts'")
    group.addoption('--fixture-graph-output-type',

please document in the readme

---

Comments from Reviewable

[fruch]

Review status: 0 of 7 files reviewed at latest revision, 2 unresolved discussions.

---

pytest_fixture_tools/plugin.py, line 39 at r3 (raw file):

Previously, bubenkoff (Anatoly Bubenkov) wrote…

please document in the readme

Done.

---

pytest_fixture_tools/plugin.py, line 42 at r3 (raw file):

Previously, bubenkoff (Anatoly Bubenkov) wrote…

please document in the readme

Done.

---

Comments from Reviewable

[coveralls]

Changes Unknown when pulling 02fa7fd on fruch:master into ** on pytest-dev:master**.

[bubenkoff]

Reviewed 3 of 5 files at r1, 3 of 4 files at r3, 1 of 1 files at r4.
Review status: all files reviewed at latest revision, 2 unresolved discussions.

---

Comments from Reviewable

[bubenkoff]

---

Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable

[mikeage]

Review status: all files reviewed at latest revision, 2 unresolved discussions, all commit checks successful.

---

pytest_fixture_tools/plugin.py, line 131 at r4 (raw file):

            loc = getlocation(fixture_data[0].func, curdir)
            if 'pytest_vgw' in loc:

I'm pretty sure this doesn't belong here

---

pytest_fixture_tools/plugin.py, line 158 at r4 (raw file):

            tw.line("created {}.{}.".format(filename, output_type))
        except Exception:
            tw.line("grpahvis wasn't found in PATH")

graphviz

---

Comments from Reviewable

[fruch]

Review status: 6 of 7 files reviewed at latest revision, 2 unresolved discussions.

---

pytest_fixture_tools/plugin.py, line 131 at r4 (raw file):

Previously, mikeage (Mike Miller) wrote…

I'm pretty sure this doesn't belong here

Done.

---

pytest_fixture_tools/plugin.py, line 158 at r4 (raw file):

Previously, mikeage (Mike Miller) wrote…

graphviz

Done.

---

Comments from Reviewable

[coveralls]

Changes Unknown when pulling eb268e4 on fruch:master into ** on pytest-dev:master**.

[fruch]

@bubenkoff you gave LGTM on it ? anything else is missing ? is it waiting for @mikeage to approve his comments ? (this reviewable is a bit confusing)

[amakhnach]

Copy-pasted docstring.

[fruch]

oops, lazy me. will fix it tomorrow once I'm at my laptop again.

[coveralls]

Changes Unknown when pulling 33e4382 on fruch:master into ** on pytest-dev:master**.

[amakhnach]

LGTM. Merging.