Skip to content

Missing error handling in SET_COUNT macro in _testinternalcapi.c #133891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sobolevn opened this issue May 11, 2025 · 0 comments
Closed

Missing error handling in SET_COUNT macro in _testinternalcapi.c #133891

sobolevn opened this issue May 11, 2025 · 0 comments
Assignees
@sobolevn
Labels
3.14 bugs and security fixes 3.15 new features, bugs and security fixes extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented May 11, 2025 •
edited by bedevere-app bot
Loading

Bug report

Refs #133265

Right here PyLong_FromLong can in theory (unlikely in practice) return NULL. It is missing this check. I understand that this is a test code, but I also don't see a reason why we should not be explicit about it.

cpython/Modules/_testinternalcapi.c

Line 1045 in 13cb8ca

#define SET_COUNT(DICT, STRUCT, NAME) \

cc @ericsnowcurrently

I have a PR ready.

Linked PRs
@sobolevn sobolevn self-assigned this May 11, 2025
@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error extension-modules C modules in the Modules dir labels May 11, 2025
sobolevn added a commit to sobolevn/cpython that referenced this issue May 11, 2025
@sobolevn
pythongh-133891: Add missing error check to SET_COUNT macro in `_te…
69b8adf 
…stinternalcapi.c`
@bedevere-app bedevere-app bot mentioned this issue May 11, 2025
Merged
@sobolevn sobolevn changed the title Missing error handling in Missing error handling in SET_COUNT macro in _testinternalcapi.c May 11, 2025
sobolevn added a commit that referenced this issue May 31, 2025
@sobolevn
gh-133891: Add missing error check to SET_COUNT macro in `_testinte…
cebae97 
…rnalcapi.c` (#133892)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 31, 2025
@sobolevn @miss-islington
pythongh-133891: Add missing error check to SET_COUNT macro in `_te…
7bd50e1 
…stinternalcapi.c` (pythonGH-133892)

(cherry picked from commit cebae97)

Co-authored-by: sobolevn <mail@sobolevn.me>
@bedevere-app bedevere-app bot mentioned this issue May 31, 2025
Merged
sobolevn added a commit that referenced this issue May 31, 2025
@miss-islington @sobolevn
[3.14] gh-133891: Add missing error check to SET_COUNT macro in `_t…
a8708f7 
…estinternalcapi.c` (GH-133892) (#134988)

gh-133891: Add missing error check to `SET_COUNT` macro in `_testinternalcapi.c` (GH-133892)
(cherry picked from commit cebae97)

Co-authored-by: sobolevn <mail@sobolevn.me>
@picnixz picnixz added 3.14 bugs and security fixes 3.15 new features, bugs and security fixes labels May 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sobolevn sobolevn

Labels
3.14 bugs and security fixes 3.15 new features, bugs and security fixes extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sobolevn @picnixz