Skip to content

Use implemenation-specific I/O open / constructors in tests #133982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cmaloney opened this issue May 13, 2025 · 0 comments
Open

Use implemenation-specific I/O open / constructors in tests #133982

cmaloney opened this issue May 13, 2025 · 0 comments
Labels
tests Tests in the Lib/test dir topic-IO type-bug An unexpected behavior, bug, or error

Comments

@cmaloney
Copy link
Contributor

cmaloney commented May 13, 2025 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

Most I/O tests are setup for running on multiple implementations. As tests have been added for bug fixes some now use open() or the class constructor directly instead of the self. version which does implementation delegation. This means that some features are not tested when the I/O module implementation is changed (ex. _io, _pyio).

I'm planning to use this as a meta issue as I find individual cases and update the test, fixing up implementations as needed to get tests passing.

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs
@cmaloney cmaloney added the type-bug An unexpected behavior, bug, or error label May 13, 2025
cmaloney added a commit to cmaloney/cpython that referenced this issue May 13, 2025
@cmaloney
pythongh-133982: Update test_bufio to use self.open
4f692d5
@bedevere-app bedevere-app bot mentioned this issue May 13, 2025
Merged
@cmaloney cmaloney mentioned this issue May 13, 2025
Merged
@ZeroIntensity ZeroIntensity added the tests Tests in the Lib/test dir label May 14, 2025
cmaloney added a commit to cmaloney/cpython that referenced this issue May 18, 2025
@cmaloney
pythongh-133982: Run unclosed file test on all io implementations
5d24e46 
Update `test_io` `_check_warn_on_dealloc` to use `self.` to dispatch to
different I/O implementations.

Update the `_pyio` implementation to match expected behavior, using the
same `_dealloc_warn` design as the C implementation uses to report the
topmost `__del__` object.
cmaloney added a commit to cmaloney/cpython that referenced this issue May 18, 2025
@cmaloney
pythongh-133982: Run unclosed file test on all io implementations
cd3b196 
Update `test_io` `_check_warn_on_dealloc` to use `self.` to dispatch to
different I/O implementations.

Update the `_pyio` implementation to match expected behavior, using the
same `_dealloc_warn` design as the C implementation uses to report the
topmost `__del__` object.
@bedevere-app bedevere-app bot mentioned this issue May 18, 2025
Merged
ambv pushed a commit that referenced this issue May 21, 2025
@cmaloney
gh-133982: Update test_bufio to use self.open (gh-133983)
84d5f8d
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 21, 2025
@cmaloney @miss-islington
pythongh-133982: Update test_bufio to use self.open (pythongh-133983)
09ab621 
(cherry picked from commit 84d5f8d)

Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
@bedevere-app bedevere-app bot mentioned this issue May 21, 2025
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 21, 2025
@cmaloney @miss-islington
pythongh-133982: Update test_bufio to use self.open (pythongh-133983)
f20976d 
(cherry picked from commit 84d5f8d)

Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
@bedevere-app bedevere-app bot mentioned this issue May 21, 2025
Merged
ambv pushed a commit that referenced this issue May 21, 2025
@cmaloney
gh-133982: Run unclosed file test on all io implementations (gh-134165)
5b0e827 
Update `test_io` `_check_warn_on_dealloc` to use `self.` to dispatch to
different I/O implementations.

Update the `_pyio` implementation to match expected behavior, using the
same `_dealloc_warn` design as the C implementation uses to report the
topmost `__del__` object.

The FileIO one now matches all the others, so can use IOBase. There was
a missing check on closing (self._fd must be valid), add that check
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 21, 2025
@cmaloney @miss-islington
pythongh-133982: Run unclosed file test on all io implementations (py…
0b27e08 
…thongh-134165)

Update `test_io` `_check_warn_on_dealloc` to use `self.` to dispatch to
different I/O implementations.

Update the `_pyio` implementation to match expected behavior, using the
same `_dealloc_warn` design as the C implementation uses to report the
topmost `__del__` object.

The FileIO one now matches all the others, so can use IOBase. There was
a missing check on closing (self._fd must be valid), add that check
(cherry picked from commit 5b0e827)

Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 21, 2025
@cmaloney @miss-islington
pythongh-133982: Run unclosed file test on all io implementations (py…
4f82e8d 
…thongh-134165)

Update `test_io` `_check_warn_on_dealloc` to use `self.` to dispatch to
different I/O implementations.

Update the `_pyio` implementation to match expected behavior, using the
same `_dealloc_warn` design as the C implementation uses to report the
topmost `__del__` object.

The FileIO one now matches all the others, so can use IOBase. There was
a missing check on closing (self._fd must be valid), add that check
(cherry picked from commit 5b0e827)

Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
This was referenced May 21, 2025
Merged
Merged
ambv pushed a commit that referenced this issue May 21, 2025
@miss-islington @cmaloney
[3.14] gh-133982: Update test_bufio to use self.open (gh-133983) (gh-…
c612a4d 
…134428)

(cherry picked from commit 84d5f8d)

Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
ambv pushed a commit that referenced this issue May 21, 2025
@miss-islington @cmaloney
[3.13] gh-133982: Update test_bufio to use self.open (gh-133983) (gh-…
de6d199 
…134429)

(cherry picked from commit 84d5f8d)

Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
ambv pushed a commit that referenced this issue May 21, 2025
@miss-islington @cmaloney
[3.14] gh-133982: Run unclosed file test on all io implementations (g…
fade04e 
…h-134165) (gh-134433)

Update `test_io` `_check_warn_on_dealloc` to use `self.` to dispatch to
different I/O implementations.

Update the `_pyio` implementation to match expected behavior, using the
same `_dealloc_warn` design as the C implementation uses to report the
topmost `__del__` object.

The FileIO one now matches all the others, so can use IOBase. There was
a missing check on closing (self._fd must be valid), add that check
(cherry picked from commit 5b0e827)

Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
ambv pushed a commit that referenced this issue May 21, 2025
@miss-islington @cmaloney
[3.13] gh-133982: Run unclosed file test on all io implementations (g…
e1e8533 
…h-134165) (gh-134434)

Update `test_io` `_check_warn_on_dealloc` to use `self.` to dispatch to
different I/O implementations.

Update the `_pyio` implementation to match expected behavior, using the
same `_dealloc_warn` design as the C implementation uses to report the
topmost `__del__` object.

The FileIO one now matches all the others, so can use IOBase. There was
a missing check on closing (self._fd must be valid), add that check
(cherry picked from commit 5b0e827)

Co-authored-by: Cody Maloney <cmaloney@users.noreply.github.com>
lkollar pushed a commit to lkollar/cpython that referenced this issue May 26, 2025
@cmaloney @lkollar
pythongh-133982: Update test_bufio to use self.open (pythongh-133983)
dad0266
lkollar pushed a commit to lkollar/cpython that referenced this issue May 26, 2025
@cmaloney @lkollar
pythongh-133982: Run unclosed file test on all io implementations (py…
53b4cf7 
…thongh-134165)

Update `test_io` `_check_warn_on_dealloc` to use `self.` to dispatch to
different I/O implementations.

Update the `_pyio` implementation to match expected behavior, using the
same `_dealloc_warn` design as the C implementation uses to report the
topmost `__del__` object.

The FileIO one now matches all the others, so can use IOBase. There was
a missing check on closing (self._fd must be valid), add that check
cmaloney added a commit to cmaloney/cpython that referenced this issue Jun 10, 2025
@cmaloney
pythongh-133982: Use self.open in test_largefile
3c8bc35
cmaloney added a commit to cmaloney/cpython that referenced this issue Jun 10, 2025
@cmaloney
pythongh-133982: Use implementation-specific open in test_fileio Othe…
9e705f1 
…rFileTests
This was referenced Jun 10, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir topic-IO type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cmaloney @picnixz @ZeroIntensity