Skip to content

gh-133866: remove deprecated and undocumented function ctypes.SetPointerType #133869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented May 11, 2025

@picnixz
Copy link
Member Author

picnixz commented May 11, 2025

Let's discuss on the issue if we can also remove the C interface as Kumar wanted.

Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also remove the note from Doc/deprecations/pending-removal-in-3.15.rst?

@picnixz
Copy link
Member Author

picnixz commented May 15, 2025

Could you also remove the note from Doc/deprecations/pending-removal-in-3.15.rst?

Are the docs for 3.14 served from the main branch or the 3.14 branch? if it's from the main branch, we need to preserve the file.

Note: I think we cannot delete them because they are built from the main branch.

Co-authored-by: Petr Viktorin <encukou@gmail.com>
@picnixz picnixz requested a review from encukou May 20, 2025 10:56
@encukou
Copy link
Member

encukou commented May 29, 2025

3.14 docs are built from the 3.14 branch. There are also 3.15 (dev) docs, though I see they don't yet always appear in the switcher.
Anyway, pending-removal-in-3.15.rst also lists some other API that's already gone; it'll need another cleanup pass.

Thank you for removing this!

@encukou encukou merged commit cafbcd6 into python:main May 29, 2025
39 checks passed
@mhsmith
Copy link
Member

mhsmith commented May 29, 2025

This PR appears to have broken the Lint check on the main branch: https://github.com/python/cpython/actions/runs/15324974930.

@encukou
Copy link
Member

encukou commented May 30, 2025

Indeed, a lint check was quietly added while this was on review.

Anyway, Victor fixed it before I got to your comment :)

@picnixz picnixz deleted the cleanup/315/ctypes-set-pointer-type-133866 branch May 30, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants