gh-133604: remove deprecated java_ver function
#133888
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Doc/whatsnew/3.15.rst
Outdated
| platform | ||
| -------- | ||
|
|
||
| * The deprecated :func:`!platform.java_ver` function. |
There was a problem hiding this comment.
| * The deprecated :func:`!platform.java_ver` function. | |
| * Removed the deprecated :func:`!platform.java_ver` function. |
To save Benedikt copy-editing it later. (See line 133)
You can also link this pr. (See line 134 as an example)
There was a problem hiding this comment.
@StanFromIreland thank you! done
Lib/platform.py
Outdated
| @@ -31,6 +31,7 @@ | |||
| # | |||
| # <see CVS and SVN checkin messages for history> | |||
| # | |||
| # 1.1.0 - removed deprecated java_ver() | |||
There was a problem hiding this comment.
Not noteworthy enough IMO. These are rarely updated, but it is up to @malemburg in the end.
There was a problem hiding this comment.
No need to add to that list anymore. The checkin messages provide enough history.
There was a problem hiding this comment.
You may want to change # <see CVS and SVN checkin messages for history> to # <see checkin messages for history>
There was a problem hiding this comment.
@malemburg thank you! done
Doc/whatsnew/3.15.rst
Outdated
| * Removed the deprecated :func:`!platform.java_ver` function. | ||
| (Contributed by Alexey Makridenko in :gh:`133888`.) |
There was a problem hiding this comment.
| * Removed the deprecated :func:`!platform.java_ver` function. | |
| (Contributed by Alexey Makridenko in :gh:`133888`.) | |
| * Removed the :func:`!platform.java_ver` function, | |
| which was deprecated since Python 3.13. | |
| (Contributed by Alexey Makridenko in :gh:`133888`.) |
The link should be the issue, not the PR.
There was a problem hiding this comment.
thank you! fixed it
| @@ -0,0 +1 @@ | |||
| Remove deprecated function :func:`!platform.java_ver`. | |||
There was a problem hiding this comment.
| Remove deprecated function :func:`!platform.java_ver`. | |
| Remove :func:`!platform.java_ver` which was deprecated since Python 3.13. |
There was a problem hiding this comment.
thank you! fixed it
… 3.15 release notes
|
Hmm, apparently, Github changed its mind about the need to rebase. |
|
@StanFromIreland Do want to review again ? Otherwise, I'll merge the PR soon. |
|
Thanks, @makridenko, for your work on this. |
|
Apologies I was unavailable. |
platform.java_ver#133604📚 Documentation preview 📚: https://cpython-previews--133888.org.readthedocs.build/