gh-132983: Call Py_XDECREF rather than PyObject_GC_Del in failed __new__ #133962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will call tp_dealloc and clear all members.
13 tasks
This was referenced May 13, 2025
There was a problem hiding this comment.
See also https://github.com/python/cpython/pull/133924/files#r2084922874
There may be other similar errors in these files.
|
I'll merge to fix the tier-1 buildbot; further fix-ups welcome. |
serhiy-storchaka
approved these changes
May 13, 2025
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Sorry, @encukou, I could not cleanly backport this to |
|
Thanks for the fix & merge @encukou -- backport will fail as the original commit isn't yet backported. |
AA-Turner
added
needs backport to 3.14
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 20, 2025
…d __new__ (pythonGH-133962) Call Py_XDECREF rather than PyObject_GC_Del in failed __new__ This will call tp_dealloc and clear all members. (cherry picked from commit e575190) Co-authored-by: Petr Viktorin <encukou@gmail.com>
|
GH-134305 is a backport of this pull request to the 3.14 branch. |
AA-Turner
pushed a commit
that referenced
this pull request
May 20, 2025
…ed __new__ (GH-133962) (#134305) gh-132983: Call Py_XDECREF rather than PyObject_GC_Del in failed __new__ (GH-133962) Call Py_XDECREF rather than PyObject_GC_Del in failed __new__ This will call tp_dealloc and clear all members. (cherry picked from commit e575190) Co-authored-by: Petr Viktorin <encukou@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will call tp_dealloc and clear all members.