Skip to content

gh-106213: Shorten Emscripten wasm-gc trampoline by a little #133984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

gh-106213: Shorten Emscripten wasm-gc trampoline by a little #133984

merged 1 commit into from
May 20, 2025

Conversation

hoodmane
Copy link
Contributor

@hoodmane hoodmane commented May 13, 2025 •
edited
Loading

I found out about the if instruction which lets us have slightly shorter code here.

@bedevere-app bedevere-app bot mentioned this pull request May 13, 2025
Closed
@hoodmane
pythongh-106213 Shorten Emscripten trampolines by a little
de6ffa6 
I found out about the `if` instruction which lets us have slightly
shorter code here.
@hoodmane hoodmane force-pushed the shorter-emscripten-wasm-gc-trampoline branch from 5680660 to de6ffa6 Compare May 13, 2025 20:38
@hoodmane hoodmane changed the title gh-121700 Shorten Emscripten trampolines by a little gh-106213 Shorten Emscripten wasm-gc trampolines by a little May 13, 2025
@bedevere-app bedevere-app bot mentioned this pull request May 13, 2025
Closed
@hoodmane hoodmane changed the title gh-106213 Shorten Emscripten wasm-gc trampolines by a little gh-106213 Shorten Emscripten wasm-gc trampoline by a little May 13, 2025
@freakboy3742 freakboy3742 added the needs backport to 3.14 bugs and security fixes label May 20, 2025
@freakboy3742 freakboy3742 changed the title gh-106213 Shorten Emscripten wasm-gc trampoline by a little gh-106213: Shorten Emscripten wasm-gc trampoline by a little May 20, 2025
freakboy3742
freakboy3742 approved these changes May 20, 2025
View reviewed changes
Copy link
Contributor

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@freakboy3742 freakboy3742 merged commit 3b7888b into python:main May 20, 2025
46 checks passed
@miss-islington-app
Copy link

Thanks @hoodmane for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2025
@hoodmane @miss-islington
pythongh-106213: Shorten Emscripten wasm-gc trampoline by a little (p…
f4a6798 
…ythonGH-133984)

Using the if instruction results in slightly shorter trampoline code.
(cherry picked from commit 3b7888b)

Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented May 20, 2025

GH-134376 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 20, 2025
freakboy3742 pushed a commit that referenced this pull request May 20, 2025
@miss-islington @hoodmane
[3.14] gh-106213: Shorten Emscripten wasm-gc trampoline by a little (G…
2d90cc8 
…H-133984) (#134376)

Using the if instruction results in slightly shorter trampoline code.
(cherry picked from commit 3b7888b)

Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>
lkollar pushed a commit to lkollar/cpython that referenced this pull request May 26, 2025
@hoodmane @lkollar
pythongh-106213: Shorten Emscripten wasm-gc trampoline by a little (p…
b42ee0a 
…ython#133984)

Using the if instruction results in slightly shorter trampoline code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@freakboy3742 freakboy3742

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoodmane @freakboy3742