-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
gh-115119: removed implicit fallback to the bundled libmpdec #134078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
14266c8
39d1e6b
b328702
94ce315
fed39e1
4c98b8d
6cd1730
9d29df1
b733718
d53bdf3
c3a1889
45544d9
8413e6f
9690208
f0e6757
1eca085
73f0729
cece14c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -257,6 +257,8 @@ Build changes | |
* Removed implicit fallback to the buildled copy of the ``libmpdec`` library. | ||
skirpichev marked this conversation as resolved.
Show resolved
Hide resolved
|
||
Now this should be explicitly enabled with :option:`--with-system-libmpdec` | ||
set to ``no`` or with :option:`!--without-system-libmpdec`. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does the devguide need updating? For example the macOS build instructions say to use https://devguide.python.org/getting-started/setup-building/#install-dependencies There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we can just drop this option. It's specified in 3.13+ instructions (where it's default to "yes"). I'll prepare a patch. |
||
The :option:`!--without-libmpdec` should be used to permit building of | ||
the CPython without the ``_decimal`` module. | ||
skirpichev marked this conversation as resolved.
Show resolved
Hide resolved
|
||
(Contributed by Sergey B Kirpichev in :gh:`115119`.) | ||
|
||
|
||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Uh oh!
There was an error while loading. Please reload this page.